freebsd add subset of libprocstat

[devnexen]

No description provided.

[rust-highfive]

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

[JohnTitor]

@bors r+

[bors]

📌 Commit 735c993 has been approved by JohnTitor

[bors]

⌛ Testing commit 735c993 with merge 427dc35...

[bors]

💔 Test failed - checks-actions

[bors]

☔ The latest upstream changes (presumably #2337) made this pull request unmergeable. Please resolve the merge conflicts.

[JohnTitor]

@bors r+

[bors]

📌 Commit be8fc00 has been approved by JohnTitor

[bors]

⌛ Testing commit be8fc00 with merge 9247b83...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

Seems you messed up a branch by a rebase.

[JohnTitor]

@bors r+

[bors]

📌 Commit 250965a has been approved by JohnTitor

[bors]

⌛ Testing commit 250965a with merge b82289f...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing b82289f to master...

[m-ou-se]

This change broke the freebsd build in the rust-lang/rust CI. See rust-lang/rust#88478 (comment)

/usr/local/x86_64-unknown-freebsd11/bin/ld: cannot find -lprocstat

[lnicola]

Maybe libprocstat needs to be installed on the system?

[devnexen]

normally freebsd comes with since it s a system library not a third party package one and even looking at the git repo in the 11.0 release era it was already that way https://github.com/freebsd/freebsd-src/tree/releng/11.0/lib

[lnicola]

Well, I ran ./src/ci/docker/run.sh dist-x86_64-freebsd on my branch (oh well, I just wanted a shell, not a dist build) and got the same error:

  = note: /usr/local/x86_64-unknown-freebsd11/bin/ld: cannot find -lprocstat
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

So this is a Docker container, not a real FreeBSD install, right? Then it could be missing some libraries.

[devnexen]

It seems ; you did all right in your side.

[m-ou-se]

cc @rust-lang/infra ^

[pietroalbini]

We're cross-compiling FreeBSD from a Linux container, yes. https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/dist-x86_64-freebsd/Dockerfile would need to be updated to make sure the library is present, but I'm not that familiar with FreeBSD cross-compilation so can't give more accurate pointers :(

[devnexen]

would it be possible to do similarly as here instead ? https://github.com/uutils/coreutils/blob/2bd556e252fd562777cabe052a2eb811d44c3167/.github/workflows/CICD.yml#L534

[pietroalbini]

That's not really feasible with our current CI configuration: we're using cross-compilation for most platforms (everything but Windows and macOS) to standardize our CI as much as possible, and running FreeBSD in a VM would add too much complexity.

I took a quick look at the Docker image, and it seems like the relevant libraries are extracted here, maybe try to include the missing library? https://github.com/rust-lang/rust/blob/e2750baf53aaa60db95f10759f6cf9463dc5a6bd/src/ci/docker/scripts/freebsd-toolchain.sh#L52-L58

[devnexen]

ah right in that case it makes sense.