-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solarish: define IP_BOUND_IF
and IPV6_BOUND_IF
#4287
Conversation
# Description These socket options are currently defined only on macOS and friends, but they exist on illumos and Solaris as well. This commit defines these socket options on solarish operating systems. # Sources On Solaris, see the man page [`ip(7P)`]. I'd like to provide a link to the illumos manual pages, but apparently https://illumos.org/man seems to be impacted by today's AWS outage. The constants are defined in `/usr/include/netinet/in.h`: ```console eliza@atrium ~ $ uname -a SunOS atrium 5.11 helios-2.0.22827 i86pc i386 i86pc eliza@atrium ~ $ rg 'IP(V6)?_BOUND_IF' /usr/include /usr/include/netinet/in.h 978:#define IP_BOUND_IF 0x41 /* bind socket to an ifindex */ 1311:#define IPV6_BOUND_IF 0x41 /* bind to an ifindex */ ``` [`ip(7P)`]: https://docs.oracle.com/cd/E86824_01/html/E54777/ip-7p.html # Checklist - [x] Relevant tests in `libc-test/semver` have been updated - [x] No placeholder or unstable values like `*LAST` or `*MAX` are included (see [rust-lang#3131](rust-lang#3131)) - [x] Tested locally (`cd libc-test && cargo test --target mytarget`); especially relevant for platforms that may not be checked in CI
I'd like to see these changes backported to v0.2; I'm not sure if I can just stick @rustbot label stable-nominated in my comment or if that requires a maintainer? |
@rustbot label stable-nominated |
The CI failure for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Illumos headers look consistent at https://github.com/illumos/illumos-gate/blob/45e5fcdea08b7ec8a83dbdd9ece08abb6e5ed569/usr/src/uts/common/netinet/in.h#L981 and https://github.com/illumos/illumos-gate/blob/45e5fcdea08b7ec8a83dbdd9ece08abb6e5ed569/usr/src/uts/common/netinet/in.h#L1314.
Cc @psumbera for Solaris.
Description
These socket options are currently defined only on macOS and friends, but they exist on illumos and Solaris as well.
This commit defines these socket options on solarish operating systems.
Sources
On Solaris, see the man page
ip(7P)
.I'd like to provide a link to the illumos manual pages, but apparently https://illumos.org/man seems to be impacted by today's AWS outage.
The constants are defined in
/usr/include/netinet/in.h
:Checklist
libc-test/semver
have been updated*LAST
or*MAX
are included (see #3131)cd libc-test && cargo test --target mytarget
); especially relevant for platforms that may not be checked in CI