Skip to content

Unix: Add sigqueue #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unix: Add sigqueue #4620

wants to merge 1 commit into from

Conversation

yshui
Copy link

@yshui yshui commented Aug 7, 2025

Description

Add prototype for sigqueue

Sources

https://github.com/bminor/glibc/blob/8543577b04ded6d979ffcc5a818930e4d74d0645/include/signal.h#L50-L51
https://github.com/bminor/musl/blob/8fd5d031876345e42ae3d11cc07b962f8625bc3b/include/signal.h#L228

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot rustbot added the O-unix label Aug 7, 2025
@yshui yshui force-pushed the main branch 6 times, most recently from c895135 to 50e3c82 Compare August 7, 2025 23:50
@yshui yshui marked this pull request as ready for review August 8, 2025 00:09
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the PR description with permalinks to the relevant headers.

@tgross35
Copy link
Contributor

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@yshui
Copy link
Author

yshui commented Aug 11, 2025

@rustbot ready

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, from the PR template:

>     * [ ]  Relevant tests in `libc-test/semver` have been updated

@tgross35 tgross35 changed the title Add sigqueue Unix: Add sigqueue Aug 15, 2025
@tgross35
Copy link
Contributor

Looking into this more, I'm not seeing this for OpenBSD or for Android. I don't think it's a safe assumption that this is available on all Unix platforms except Apple and emscripten.

So, please add one definition in src/unix/bsd that excludes target_vendor = "apple", and add one in src/unix/linux_like/linux. Then the semver files freebsd.txt, linux.txt, and netbsd.txt should be updated.

@yshui
Copy link
Author

yshui commented Aug 15, 2025

kinda in a weird situation:

android has it.
illumos seems to have it. (can't find the header, though)
cygwin has it.
redox has it, IIUC
qnx neutrino has it
aix has it
haiku has it

i think openbsd and hurd are the ones that don't have it.

@yshui
Copy link
Author

yshui commented Aug 15, 2025

and sigqueue is POSIX.1-2001, not an os-specific extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants