l4re: change bit widths of file offset types - #5173
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
a64dd66 to
66c2f42
Compare
dybucc
changed the title
66c2f42 to
244c00b
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
changed the title
244c00b to
f0bf0bf
Compare
This comment has been minimized.
This comment has been minimized.
caac209 to
e16db76
Compare
|
I'm pretty fine deprecating these since the platform has pretty low use, but we should figure out the other uclibc PR first. @SnoozeThis #5165 -> remove label S-blocked, add label S-waiting-on-review |
|
(https://snoozeth.is/u1Hjq3aITKU) I will wait until #5165 is merged and then add label S-waiting-on-review and remove label S-blocked. @rustbot claim. |
e16db76 to
0c5f454
Compare
This comment has been minimized.
This comment has been minimized.
e1d5fdc to
fb8fb9e
Compare
This comment has been minimized.
This comment has been minimized.
fb8fb9e to
a2d1a13
Compare
This comment has been minimized.
This comment has been minimized.
a2d1a13 to
e09560e
Compare
|
@rustbot blocked |
rustbot
added
S-waiting-on-review
S-blocked
and removed
S-blocked
S-waiting-on-review
labels
This comment has been minimized.
This comment has been minimized.
Add deprecation warnings to LFS64 bindings under L4Re uClibc. This patch adds notices to types and routines. The only supported target is 64-bits wide. Its suffixed and unsuffixed types should always be equivalent.
e09560e to
ae43a7e
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
Shape looks fine but I didn't look at the structs in detail. Pinging @farao to take a look at that.
| pub type flock64 = flock; | ||
| pub type stat64 = stat; |
There was a problem hiding this comment.
Should these be deprecated as well?
|
|
||
| #[deprecated( | ||
| since = "0.2.187", | ||
| note = "Use `fsblkcnt_t` instead. LFS64 are being phased out. See #4805." |
There was a problem hiding this comment.
"Use fsblkcnt_t instead, LFS64 are being phased out. See #4805."
.->, to flow a bit better, and making it clear which repo. Applies a few places.
There was a problem hiding this comment.
Also the version should ideally be updated
| deprecated( | ||
| since = "0.2.187", | ||
| note = "Use `freopen` instead. LFS64 are being phased out. See #4805." | ||
| ) |
There was a problem hiding this comment.
target_os = "l4re" is sufficient here, there's only uclibc and other libcs would probably act the same. Applies a few places.
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot label +S-waiting-on-maintainer Also @farao we don't have a target maintainer for l4re, please add yourself if you're fine being pinged for l4re things (should be very low volume). Just a PR adding a file to https://github.com/rust-lang/rust/tree/c9ff496891c278ad660bc0ab85c1f0b72059464a/src/doc/rustc/src/platform-support and updating https://github.com/rust-lang/rust/blob/c9ff496891c278ad660bc0ab85c1f0b72059464a/src/doc/rustc/src/platform-support.md. |
4 participants
Description
This PR deprecates a number of symbols from the
unix/linux_like/l4remodule. This has also come with further deprecations and modifications in other top-level modules.At present, the definitions in upstream l4re-core are always 64-bit wide for the 64-bit targets we seem to support in this module. Though rustc only has support for x86_64 under this target OS.
Sources
Sources on the uClibc changes are documented in #5165. A regex search of the affected symbols on l4re-core's
libcdirectory reveals no modifications in their patches would necessitate changes in this patch.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated