add environ to unix - #5339
Conversation
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
|
3bb2917 to
ea35ffa
Compare
|
environ now linux-gnu only. glibc declares it in <unistd.h> behind _GNU_SOURCE. no ctest skips elsewhere. commit messages link to headers. |
ea35ffa to
edd0b34
Compare
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
|
9904a3b to
c98e663
Compare
c98e663 to
ae85f0a
Compare
This comment has been minimized.
This comment has been minimized.
posix-mandated variable, available on all unix. no cfg gates — it's a spec thing not a header thing.
posix exec spec mandates it. no macos header, thats by design. linker provides it everywhere.
apple headers dont have it (by design). linux gets it from <unistd.h>. no skip needed there.
same issue as apple — not declared in freebsd headers by default.
https://man7.org/linux/man-pages/man7/environ.7.html https://man7.org/linux/man-pages/man7/feature_test_macros.7.html glibc declares environ in <unistd.h> behind _GNU_SOURCE. Other libcs dont declare it in headers.
ae85f0a to
2675498
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
May as well take this but please clean up the history - 15 commits is a lot for a four line diff :)
@rustbot author




see commit messages.
libc-test/semver/unix.txtupdatedcargo test -p libc-test— 15 passedCloses #2520
@rustbot label +stable-nominated