Add libc direct tests for (get/set/unset)env functions #4679
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
RalfJung
requested changes
Nov 16, 2025
| @@ -0,0 +1,98 @@ | |||
| //@ignore-target: windows | |||
Member
There was a problem hiding this comment.
Suggested change
| //@ignore-target: windows | |
| //@ignore-target: windows # No libc |
Comment on lines
+10
to
+12
| // PATH should exist and not be null | ||
| let s = unsafe { libc::getenv(b"PATH\0".as_ptr().cast()) }; | ||
| assert!(!s.is_null()); |
Member
There was a problem hiding this comment.
Please check MIRI_ENV_VAR_TEST instead, which is set by the test harness so it should always have the value "0".
Comment on lines
+6
to
+7
| #[path = "../../utils/mod.rs"] | ||
| mod utils; |
Member
There was a problem hiding this comment.
This does not seem to be used?
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
getenv,setenvandunsetenvfunctions directly through the libc api. Related to #3179