Use generic trait parameters to minimize associated types #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves type inference by removing most associated types. For example, the following function doesn't actually work:
You actually need the constraint
Simd<T, 4>: SimdFloat<Mask = Mask<T::Mask, 4>>.With this PR, the function should look a little more like:
There are still a few instances that need associated types, but we can explore those individually to see if there's a better API.
Also, note that we now end up with a lot of instances of
Mask<<T as SimdElement>::Mask, N>. We can either remove theSimdElement::Maskassociated type with #483 or we can provide an alias to avoid writing that out.