Refactor unsizing coercion documentation #1731
Conversation
rustbot
added
the
S-waiting-on-review
WaffleLapkin
force-pushed
the
unsize_coercion_rewrite
branch
3 times, most recently
from
6f8650a to
08bec64
Compare
This comment has been minimized.
This comment has been minimized.
|
@rust-lang/types would you be able to review this? |
|
To add a bit more color, it'd be good to get a double check that the content is factually accurate before spec team takes it on for editorial review. |
| <!-- FIXME: are there more requirements for `CoerceUnsized`? --> | ||
|
|
||
| r[coerce.unsize.coerce-unsized-impls] | ||
| Types which currently implement `CoerceUnsized<_>` (assuming `T: Unsize<U>`, `'a: 'b`, `A: CoerceUnsized<B>`, `Al: Allocator`): |
There was a problem hiding this comment.
Generally I would prefer to not duplicate the list of impls from the standard library here. I assume the user can click the link to CoerceUnsized to see which impls it has?
There was a problem hiding this comment.
So, mh. Yes, users can find them in the std docs (that's where I got the impls from!).
However, if we want the reference to be prescriptive, I think we should include this. While this is library code, it controls how a language feature behaves.
But I don't have a strong opinion here, if you think that this is not useful I can remove the list.
The old one was quite confusing and also incorrect in a few places.
WaffleLapkin
force-pushed
the
unsize_coercion_rewrite
branch
from
08bec64 to
9271fdd
Compare
The old one was quite confusing and also incorrect in a few places. Follow-up to #1622.