Add the ability for rules to be specified in link definitions #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
traviscross
reviewed
Apr 1, 2025
mdbook-spec/src/lib.rs
Outdated
Comment on lines
136
to
144
| if let Some((_source_path, path)) = rules.def_paths.get(dest) { | ||
| let label = &caps["label"]; | ||
| let relative = pathdiff::diff_paths(path, current_path).unwrap(); | ||
| // Adjust paths for Windows. | ||
| let relative = relative.display().to_string().replace('\\', "/"); | ||
| return format!("[{label}]: {relative}#r-{dest}"); | ||
| } else { | ||
| return caps.get(0).unwrap().as_str().to_string(); | ||
| } |
There was a problem hiding this comment.
Since all branches diverge, it makes sense to move the return outward. Will update.
There was a problem hiding this comment.
Actually, of course, here we don't need the return at all.
traviscross
reviewed
Apr 1, 2025
Comment on lines
+133
to
+134
| MD_LINK_REFERENCE_DEFINITION | ||
| .replace_all(&chapter.content, |caps: &Captures<'_>| { |
There was a problem hiding this comment.
This is OK of course, but as you mention, it'd be better to do it otherwise. Remind me to ask you sometime about what the challenges are here.
traviscross
reviewed
Apr 1, 2025
Comment on lines
+123
to
+128
| /// For example: | ||
| /// ```markdown | ||
| /// See [this rule]. | ||
| /// | ||
| /// [this rule]: expr.array | ||
| /// ``` |
There was a problem hiding this comment.
I'm adding an example use of this to introduction page also.
traviscross
force-pushed
the
rule-ref-link
branch
from
0c55417 to
f44f16e
Compare
This adds the ability to link to rules from a link definition. For example: ```markdown See [this rule]. [this rule]: expr.array ``` This will convert `[this rule]` to point to the link of the file for that rule. This is somewhat hacky, as parsing markdown with regex is unwise (and this is intentionally incomplete), and could maybe be done more efficiently.
On the introduction page, where we talk about rule identifiers, let's add an example use of putting the rule identifier in the link definition so that we have an easy way of verifying that this mechanism works as intended.
traviscross
force-pushed
the
rule-ref-link
branch
from
f44f16e to
f37173d
Compare
traviscross
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to link to rules from a link definition. For example:
This will convert
[this rule]to point to the link of the file for that rule.This is somewhat hacky, as parsing markdown with regex is unwise (and this is intentionally incomplete), and could maybe be done more efficiently.
I don't have an immediate need for this, but I have wanted this a few times in the past.