Skip to content

feat: Diagnose unresolved field, method call and call expression #14243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2023
Merged

feat: Diagnose unresolved field, method call and call expression #14243

merged 3 commits into from
Mar 3, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 3, 2023 •
edited
Loading

image

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2023
@Veykril Veykril changed the title Diagnose call expression on non-callable things feat: Diagnose unresolved field, method call and call expression Mar 3, 2023
@Veykril
Copy link
Member Author

Veykril commented Mar 3, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit e7485a0 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 3, 2023

⌛ Testing commit e7485a0 with merge 7c092a1...

@bors
Copy link
Contributor

bors commented Mar 3, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7c092a1 to master...

@bors bors merged commit 7c092a1 into rust-lang:master Mar 3, 2023
This was referenced Mar 3, 2023
Closed
Merged
@Veykril Veykril deleted the inference-diags branch March 3, 2023 20:15
@lenstr
Copy link

lenstr commented Mar 6, 2023

Hi! Just updated to the latest version of rust-analyzer and now all my diesel models are red

image

@Veykril
Copy link
Member Author

Veykril commented Mar 6, 2023

You can put unresolved-method in the rust-analyzer.diagnostics.disabled setting to silence the warning, diesel is known to cause problems for us so this is not too surprising I guess... (Let me make that an issue though)

@Veykril Veykril mentioned this pull request Mar 6, 2023
Closed
@martijnarts
Copy link

martijnarts commented Mar 9, 2023 •
edited
Loading

Hey all, I don't know if this helps but I'm seeing an unresolved-field error on a field that definitely exists and compiles just fine. I think the problem is actually the weird dependencies I've introduced into my workspace modules though. I've reproduced it here: https://github.com/martijnarts/ra-unresolved-field-repro

Do you want me to create a new issue for this, or maybe add to the Diesel issue?

Here's what it looks like when breaking:

how-it-breaks

@Veykril
Copy link
Member Author

Veykril commented Mar 9, 2023

That looks like an interesting issue (with a nice preproduction). Could you open that as a new issue?

@martijnarts
Copy link

Created here: #14296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Veykril @bors @lenstr @martijnarts @rustbot