Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions crates/ide-completion/src/render.rs
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,8 @@ pub(crate) fn render_resolution_with_import(
import_edit: LocatedImport,
) -> Option<Builder> {
let resolution = ScopeDef::from(import_edit.original_item);
let local_name = scope_def_to_name(resolution, &ctx, &import_edit)?;
//this now just renders the alias text, but we need to find the aliases earlier and call this with the alias instead
let local_name = get_import_name(resolution, &ctx, &import_edit)?;
// This now just renders the alias text, but we need to find the aliases earlier and call this with the alias instead.
let doc_aliases = ctx.completion.doc_aliases_in_scope(resolution);
let ctx = ctx.doc_aliases(doc_aliases);
Some(render_resolution_path(ctx, path_ctx, local_name, Some(import_edit), resolution))
Expand All @@ -294,7 +294,7 @@ pub(crate) fn render_resolution_with_import_pat(
import_edit: LocatedImport,
) -> Option<Builder> {
let resolution = ScopeDef::from(import_edit.original_item);
let local_name = scope_def_to_name(resolution, &ctx, &import_edit)?;
let local_name = get_import_name(resolution, &ctx, &import_edit)?;
Some(render_resolution_pat(ctx, pattern_ctx, local_name, Some(import_edit), resolution))
}

Expand Down Expand Up @@ -357,6 +357,24 @@ pub(crate) fn render_expr(
Some(item)
}

fn get_import_name(
resolution: ScopeDef,
ctx: &RenderContext<'_>,
import_edit: &LocatedImport,
) -> Option<hir::Name> {
// FIXME: Temporary workaround for handling aliased import.
// This should be removed after we have proper support for importing alias.
// <https://github.com/rust-lang/rust-analyzer/issues/14079>

// If `item_to_import` matches `original_item`, we are importing the item itself (not its parent module).
// In this case, we can use the last segment of `import_path`, as it accounts for the aliased name.
if import_edit.item_to_import == import_edit.original_item {
import_edit.import_path.segments().last().cloned()
} else {
scope_def_to_name(resolution, ctx, import_edit)
}
}

fn scope_def_to_name(
resolution: ScopeDef,
ctx: &RenderContext<'_>,
Expand Down
51 changes: 51 additions & 0 deletions crates/ide-completion/src/tests/flyimport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1669,3 +1669,54 @@ mod module {
"#]],
);
}

#[test]
fn re_export_aliased() {
check(
r#"
mod outer {
mod inner {
pub struct BarStruct;
pub fn bar_fun() {}
pub mod bar {}
}
pub use inner::bar as foo;
pub use inner::bar_fun as foo_fun;
pub use inner::BarStruct as FooStruct;
}
fn function() {
foo$0
}
"#,
expect![[r#"
st FooStruct (use outer::FooStruct) BarStruct
md foo (use outer::foo)
fn foo_fun() (use outer::foo_fun) fn()
"#]],
);
}

#[test]
fn re_export_aliased_pattern() {
check(
r#"
mod outer {
mod inner {
pub struct BarStruct;
pub fn bar_fun() {}
pub mod bar {}
}
pub use inner::bar as foo;
pub use inner::bar_fun as foo_fun;
pub use inner::BarStruct as FooStruct;
}
fn function() {
let foo$0
}
"#,
expect![[r#"
st FooStruct (use outer::FooStruct)
md foo (use outer::foo)
"#]],
);
}