Refactor enum generation #3112
Merged
Refactor enum generation #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
jschwender/enum_refactor
branch
from
f175581 to
7d9b3e9
Compare
emilio
requested changes
Feb 9, 2025
emilio
approved these changes
Feb 10, 2025
|
Could you squash the commits as well? Thanks. |
jschwe
force-pushed
the
jschwender/enum_refactor
branch
from
0fc80e8 to
e911598
Compare
emilio
approved these changes
Feb 10, 2025
Gather all the enum variants. This allows us to simplify some logic, make the code more readable, by putting the actual code generation close together in the build method. For users, the main benefit is that Newtype enums now only have a single impl block, instead of one impl block per enum variant.
jschwe
force-pushed
the
jschwender/enum_refactor
branch
from
e911598 to
4ad0d95
Compare
@emilio Is there anything that still needs to be done to get this merged? |
@emilio Friendly ping |
|
No, sorry, I just apparently forgot to put it in the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gather all the enum variants and let the builder generate everything at once.
This allows us to simplify some logic and makes the code more readable, by putting the actual code generation close together in the build method.
For users, the main benefit is that Newtype enums now only have a single impl block, instead of one impl block per enum variant.