Avoid \u{1} prefix when the user overrode item names #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
changed the title
\u{1} is an LLVM specific extension which other rustc codegen backends
do not support.
bjorn3
force-pushed
the
better_link_name_handling
branch
from
fc322e0 to
50eb27f
Compare
|
Why does the Publish on crates.io workflow get invoked even though this PR hasn't been merged? It gives me a failure notification. https://github.com/rust-lang/rust-bindgen/actions/runs/13972867609 |
|
Right, for Mach-O all symbols get mangled to add an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\u{1}is an LLVM specific extension which other rustc codegen backends do not support.Fixes #2935