[Kobzol]

So that we can track the bindgen crates in team.

CC @emilio @rust-lang/wg-bindgen

Companion PR: rust-lang/team#2848

After this PR is merged, the CARGO_REGISTRY_TOKEN secret should be removed from this repository (and invalidated).

[DanielEScherzer]

community review

• The assert_ne changes are unrelated and just to get clippy to pass -> I already opened #3514 for that yesterday
• Does https://github.com/rust-lang/rust-bindgen/blob/3d7ec570ad932708c78a0e66d313bf17b1699854/CONTRIBUTING.md#cutting-a-new-bindgen-release need to be updated?

View changes since this review

[Kobzol]

Regarding the second point, I don't think so! Stuff should work as before. This is essentially just an authentication change.

[Kobzol]

Ok nevermind, the current release workflow is broken, it doesn't work. It has to be implemented in another way, I'll check in with the maintainers.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Kobzol]

Ok, I went back and forth on this a couple of times, the interaction with cargo-dist is tricky. I decided to just run cargo publish when a tag is pushed, in parallel with cargo-dist creating a GitHub release. I think that's the simplest solution here to avoid unnecessary complexity, because the cargo-dist workflow file is actually autogenerated, so adding custom steps to it is non-trivial.

[marcoieni]

we should update https://github.com/rust-lang/rust-bindgen/blob/main/CONTRIBUTING.md#cutting-a-new-bindgen-release

[Kobzol]

Updated the docs. Though when doing that, I realized that they were actually out of date, as they described running the publish workflow manually, but that's not how it works right now (before this PR). I wonder if the manual publishing through clicking in GitHub UI actually wouldn't be a better choice for bindgen maintainers.

Let's see what @emilio thinks.