Skip to content

Avoid literal CURRENT_RUSTC_VERSION string #17815

Description

@Mark-Simulacrum

See

if s.bytes().all(|c| matches!(c, b'0'..=b'9' | b'.')) || matches!(s, "pre 1.29.0" | "CURRENT_RUSTC_VERSION") {

This gets replaced by https://github.com/rust-lang/rust/blob/5c543b0b8c73c7b72bc8284ced4fb22ead15734d/src/tools/replace-version-placeholder/src/main.rs#L25 -- if we can avoid the literal there by e.g. checking a prefix + suffix or similar, that would be good. Otherwise we'll accidentally replace this and probably miss it in PR review eventually.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions