Skip to content

Fix suggestion unnecessary_lazy_eval #13299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Aug 24, 2024

As mentioned at #13293 improve suggestion via span_suggestion_verbose

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2024
@Alexendoo Alexendoo linked an issue Aug 24, 2024 that may be closed by this pull request
@Alexendoo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2024

📌 Commit f4fc385 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 24, 2024

⌛ Testing commit f4fc385 with merge 37948cc...

bors added a commit that referenced this pull request Aug 24, 2024
…xendoo

Fix suggestion unnecessary_lazy_eval

As mentioned at #13293 improve suggestion via span_suggestion_verbose

changelog[`unnecessary_lazy_eval`]: use span_suggestion_verbose for suggestions
@bors
Copy link
Contributor

bors commented Aug 24, 2024

💔 Test failed - checks-action_test

@Alexendoo
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Aug 24, 2024

⌛ Testing commit f4fc385 with merge 301f2c4...

@bors
Copy link
Contributor

bors commented Aug 24, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 301f2c4 to master...

@bors bors merged commit 301f2c4 into rust-lang:master Aug 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong help message suggested for unwrap_or_else
5 participants