-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question_mark: avoid incorrect suggestion when ref
binding used
#14158
question_mark: avoid incorrect suggestion when ref
binding used
#14158
Conversation
r? @Manishearth rustbot has assigned @Manishearth. Use |
46f9da1
to
a0927f9
Compare
r? clippy swamped this week |
I'm finding this code seriously hard to read, could you refactor it? If an |
I'm not sure how to refactor this code to be more readable. But, since this is a corner case and not actually important, I can change it to avoid giving wrong answers by just doing nothing. Skipping the part where it tries to figure out a working fix simplifies it a lot. |
e0c7376
to
26ff4a7
Compare
as_ref
/as_mut
if ref binding is usedref
binding used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to do the suggestion even at the cost of a little less maintainability. Could you revert the second commit (I've suggested some renames)
fab9d27
to
880f1bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️ Could you squash the commits?
880f1bf
to
0e6f7db
Compare
0e6f7db
to
4e9caa3
Compare
Sure. It's squashed. |
changelog: [
question_mark
]: avoid incorrect suggestion whenref
binding usedFixes #13417