Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just_underscores_and_digits: fix false positive in error recovery scenario #14168

Merged
merged 1 commit into from
Feb 11, 2025
Merged

just_underscores_and_digits: fix false positive in error recovery scenario #14168

merged 1 commit into from
Feb 11, 2025

Conversation

notriddle
Copy link
Contributor

Fixes #12302

changelog: [just_underscores_and_digits]: fix false positive in error recovery scenario

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 6, 2025
@notriddle notriddle force-pushed the notriddle/non-expressive-names-error-recovery branch from c7da1ff to b745b14 Compare February 6, 2025 23:06
samueltardieu
samueltardieu reviewed Feb 7, 2025
View reviewed changes
@notriddle notriddle force-pushed the notriddle/non-expressive-names-error-recovery branch from febecc7 to 1d3712f Compare February 7, 2025 23:38
blyxyas
blyxyas reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase? And in the midst of rebasing, implement this little refactor?
(We have a lint for .last() -> .next_back() on DoubleEnderIterators, maybe that should be expanded to this usecase?)

@notriddle notriddle force-pushed the notriddle/non-expressive-names-error-recovery branch from 1d3712f to a2c834c Compare February 11, 2025 16:35
@notriddle
just_underscores_and_digits: ignore empty ident
ac15a10 
Empty idents come from error recovery, and should imply that a
better error has already been emitted.
@notriddle notriddle force-pushed the notriddle/non-expressive-names-error-recovery branch from a2c834c to ac15a10 Compare February 11, 2025 16:35
blyxyas
blyxyas approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Feb 11, 2025
Merged via the queue into rust-lang:master with commit ffa1caf Feb 11, 2025
11 checks passed
@notriddle notriddle deleted the notriddle/non-expressive-names-error-recovery branch February 11, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive of just_underscores_and_digits when missing R_ANGLE when ending type prameters
4 participants
@notriddle @rustbot @samueltardieu @blyxyas