manual_slice_fill: do not initialize from the iterator
#14191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
|
r? clippy |
|
(ping @lapla-cogito who is the author of this new lint) |
|
r? clippy Still traveling |
samueltardieu
force-pushed
the
push-nwommozmsnos
branch
from
88adc95 to
3b11310
Compare
kornelski
approved these changes
Feb 11, 2025
samueltardieu
force-pushed
the
push-nwommozmsnos
branch
from
3b11310 to
7db652c
Compare
|
Rebased |
In both instances, `!assign_val.span.from_expansion()` – which is more restrictive than `span_is_local(assign_val.span)` – has been required already.
```rust
let mut tmp = vec![1, 2, 3];
for b in &mut tmp {
*b = !*b;
}
```
must not suggest the invalid `tmp.fill(!*b)`.
samueltardieu
force-pushed
the
push-nwommozmsnos
branch
from
7db652c to
44aa75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must not suggest the invalid
tmp.fill(!*b).In addition, there is another commit which cleans up two function calls with no effect.
Fix #14189
changelog: [
manual_slice_fill]: ensure that the initialization expression doesn't reference the iterator