Skip to content

Add data structures used by redundant_clone #14672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 23, 2025

Contains just the data structures used in #14599

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Apr 23, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 23, 2025
@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 23, 2025

@flip1995 Do you have any objections to running the data structure tests with miri? There's currently a few lines of unsafe code.

@flip1995
Copy link
Member

flip1995 commented May 5, 2025

Just saw this question. To also have the answer in the PR:

We discussed this in the last meeting. We should run the tests with miri, as long as it doesn't take too long, which it doesn't seem like it does. Also those tests should not run in the Rust repo (for now?), as it might be difficult to implement Clippy depending on Miri in rustc bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants