Rewrite unwrap_in_result lint
#15445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
- Lint non-`impl` functions as well. - Lint function calls in addition to method calls (such as `Option::unwrap(…)`). - Put the lint on the `unwrap` and `expect` node instead of the function signature. This lets the user `#[allow]` specific `unwrap()` or `expect()` calls. - Do not lint inside closures, `const` and `static`. - Do not mix warnings about `Option` and `Result`.
samueltardieu
force-pushed
the
issue-15439
branch
from
3f05b5e to
500f1e4
Compare
|
Lintcheck changes for 500f1e4
This comment will be updated if you push new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implfunctions as well.Option::unwrap(…)).unwrapandexpectnode instead of the function signature. This lets the user#[allow]specificunwrap()orexpect()calls.constandstatic.OptionandResult.changelog: [
unwrap_in_result]: issue lint on.unwrap()and.expect()nodes instead of the function onechangelog: [
unwrap_in_result]: also lint in functions outside implementation blockschangelog: [
unwrap_in_result]: do not mixResultandOptionFixes #15439