Skip to content

Reenable master build, unbreak CI #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Reenable master build, unbreak CI #3383

wants to merge 1 commit into from

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 30, 2018

In #3371 we disabled the master build, however we currently need master for green CI.

This attempts to reenable the master build by installing rustup-toolchain-install-master with an older rustc, temporarily till rust-lang/rust#55376 is fixed

r? @phansch

@phansch
Copy link
Member

phansch commented Oct 30, 2018

Hmm, AppVeyor fails with:

set RUST_BACKTRACE=1
cargo build --features debugging
error: toolchain 'master' does not have the binary `cargo.exe`

I'm going to retrigger the build, maybe it was just spurious. I don't see how your change could have caused that.

@phansch phansch closed this Oct 30, 2018
@phansch phansch reopened this Oct 30, 2018
@Manishearth
Copy link
Member Author

Manishearth commented Oct 30, 2018 via email

@matthiaskrgr
Copy link
Member

If nrc's fix pr lands in the next rollup (ETA 1.5 hours from now) we can simply revert the commits and run from master again.

@flip1995
Copy link
Member

Closed with #3384

@flip1995 flip1995 closed this Oct 31, 2018
@flip1995 flip1995 deleted the travis-fix branch December 19, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants