Skip to content

Fix some test failures in compiletest branch #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix some test failures in compiletest branch #3906

merged 1 commit into from
Mar 27, 2019

Conversation

felix91gr
Copy link
Contributor

Helping @oli-obk with #3905

@felix91gr felix91gr mentioned this pull request Mar 26, 2019
@mati865
Copy link
Contributor

mati865 commented Mar 26, 2019

CI errors:

error: identical conversion
  --> tests/compile-test.rs:80:16
   |
80 |     for dir in fs::read_dir(&config.src_base)? {
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `fs::read_dir(&config.src_base)?()`: `fs::read_dir(&config.src_base)?`
   |
   = note: `-D clippy::identity-conversion` implied by `-D clippy::all`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
error: identical conversion
  --> tests/compile-test.rs:83:21
   |
83 |         for file in fs::read_dir(&dir_path)? {
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `fs::read_dir(&dir_path)?()`: `fs::read_dir(&dir_path)?`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
error: aborting due to 2 previous errors

@felix91gr
Copy link
Contributor Author

I know. I couldn't get rid of those: there seems to be a regression on rustc (or possibly Clippy) that causes that lint to misbehave. See Oliver's comment here

@oli-obk oli-obk merged commit 6689fb0 into rust-lang:compiletest Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants