-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding a dev website path for the new lints.json
format and testing deployment
#7229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lints.json
format and testing deployment
Let me tell you that CI/CD has a talent for crushing those hopes.
I wanted to jump in on the CI work anyway and take over a bit. When I first set up the CI, I didn't really document it well. Especially how things work together with the release process. There are some weirdnesses to consider. I'm not sure if we should deploy the |
That made me laugh more than it should have ^^. My dreams are still alive until then.
Awesome, working on CI/CD is not my favorite part of the development process anyways. So, feel free to take over. One thing to consider would be to adapt the build and testing steps in the pipeline to include the
# Temporary fix until the old headline syntax will be replaced with the markdown ### syntax
sed -i -e 's/ \*\*/### /g' -e 's/\*\*/\\n/g' util/gh-pages/metadata_collection.json
I can easily deploy the new website to my repo for now and link to it for a preview. That wouldn't mess with the gh-pages branch and doesn't cost me anything. The drawbacks would be that you had to review all website changes at once and that the deployment wouldn't be tested beforehand, which is fine for me if you take that over 🙃. |
Perfect, then we have a deal. For some reason I like the pain that comes with CI/CD.
It should deny warnings. Maybe it doesn't deny them in the metadata collector lint, since that feature is not (and should not be) enabled during normal CI builds. Having those only caught in the dogfood test isn't ideal, but should be good enough for now.
Yes, me too. I'd like to get all of this merged in one sync / release cycle. So all the work that modifies CI should be batched into one day, where the tree is closed otherwise. This will reduce the impact that potentially breaking the deployment will have. From experience I would say that this has a high likelihood.
That would be better I think (together with my point above). You can just ping me on Zulip, if you have something ready to review or want feedback while working on it. I can then review it in your fork without a PR. |
I kind of want to quote you on that, after everything is merged ^^
I encountered this case then I added the
Awesome, I'll adapt the website to a new working state, and then we can try to find a date for this. Should I close this PR in the meantime?
👍 |
Ah thanks, I know what's going on, thanks for pointing that out! I'll prepare a fix.
Yeah, I don't think we'll merge this, but split it up in multiple other PRs. |
Deny warnings in every main sub-crate Pointed out by `@xFrednet` in #7229 (comment) This enables the same (rustc) lints in every main sub-crate: - `clippy` - `clippy_lints` - `clippy_utils` - `clippy_dev` In addition it forwards the `deny-warnings` feature to those sub-crates, so we don't miss warnings that then become a problem during sync. (I wanted to fix that before, but forgot about it, so thanks for pointing it out `@xFrednet!)` changelog: none
A new PR to feed the beast. This one simply added a new dev path to GitHub Pages and automatically deploys the new
dev-index.html
as well as alints.json
file along it. Thelints.json
file for the dev environment will be created using our new metadata collection (monster).The dev website is currently fairly broken and with that I mean: It doesn't display any lints at all. This is on purpose as this PR only aims to create the basic setup to make future reviews simpler. The adapting to the new
lints.json
format will be done on thedev-index.html
to allow a preview while not impacting our main lint list.The changes are split into two commits which will probably help with the review as the
dev-index.html
is just a straight copy fromindex.html
and doesn't have to be reviewed.This is also a test to see if the new deploy script works in the CI environment, It works locally so I have high hopes ^^
See: #7172 for the full metadata collection to-do list or to suggest a new feature in connection to it 🙃
changelog: none
r? @flip1995
This is the last branch I had in my backlog. The next one will take some time again xD.