exclude enum from derivable impls #7755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
reviewed
Oct 3, 2021
clippy_lints/src/derivable_impls.rs
Outdated
| @@ -83,6 +83,7 @@ impl<'tcx> LateLintPass<'tcx> for DerivableImpls { | |||
| if !attrs.iter().any(|attr| attr.doc_str().is_some()); | |||
| if let child_attrs = cx.tcx.hir().attrs(impl_item_hir); | |||
| if !child_attrs.iter().any(|attr| attr.doc_str().is_some()); | |||
| if !adt_def.is_enum(); | |||
There was a problem hiding this comment.
I think this should check for if adt_def.is_struct(); instead, to make sure that we don't get any FPs on unions, as they can also not derive Default. Otherwise, this looks good to me 🙃
|
Thanks! 🙃 @bors r+ |
|
📌 Commit 0ebc656 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 3, 2021
exclude enum from derivable impls fix #7753 changelog: Exclude enum from ``[`derivable_impls`]``
|
💔 Test failed - checks-action_test |
|
If the problem was Enter after changlog, I deleted it. |
|
Yes that it most likely the problem they have to be on the same line. I've updated the description 🙃 @bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7753
changelog: Exclude enum from
[`derivable_impls`]