-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add usize
cast to clippy::manual_bits
suggestion
#8677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
fe7da3b
to
26acd20
Compare
26acd20
to
1613c54
Compare
The test fails in |
1613c54
to
1b85270
Compare
Thank you for the message, I've missed the failed CI. Now it should be ready, the update only added |
1b85270
to
ba15cdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the example in doc be updated like below?
/// ### Example
/// ```rust
/// std::mem::size_of::<usize>() * 8;
/// ```
/// Use instead:
/// ```rust
/// usize::BITS as usize;
/// ```
@bors r+ Thanks! |
📌 Commit 3bd0ac7 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
A fix for the suggestion from #8213
changelog: [
manual_bits
]: The suggestion now includes a cast for proper type conversion