Skip to content

document additional labels #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

document additional labels #808

merged 1 commit into from
Feb 18, 2025

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Feb 15, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2025

r? @pietroalbini

rustbot has assigned @pietroalbini.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2025
jieyouxu
jieyouxu reviewed Feb 15, 2025
View reviewed changes
@tshepang tshepang force-pushed the patch-3 branch 2 times, most recently from 6e0929c to 71750de Compare February 17, 2025 14:27
jieyouxu
jieyouxu approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit

@tshepang tshepang force-pushed the patch-3 branch 2 times, most recently from 6ddd58c to 7778154 Compare February 18, 2025 14:57
jieyouxu
jieyouxu approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu jieyouxu merged commit bd711c5 into rust-lang:master Feb 18, 2025
1 check passed
@tshepang tshepang deleted the patch-3 branch February 18, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@pietroalbini pietroalbini

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tshepang @rustbot @jieyouxu @pietroalbini