-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use llvm-libunwind="in-tree" for Fuchsia targets #100341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
Can you also update the target docs so they don't say you need to override this anymore? |
Removing libunwind from Fuchsia target docs
173ac65
to
29238f4
Compare
Good call -- done! |
The bootstrap changes were already approved in #93604 (comment). @bors r+ rollup=never (broke last time) |
⌛ Testing commit 29238f4 with merge 24041dbeb7a469050367aa1d63309a708fc46af1... |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e8dc8bc): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
With updates to Fuchsia CI's Zircon libraries #99833, we can introduce
llvm-libunwind="in-tree"
for Fuchsia targets. This PR restores functionality removed from #93604 (comment).cc @tmandry @djkoloski