Delete the stage1 and stage0-sysroot directories when using download-rustc

[chenyukang]

Fixes #102002

[rust-highfive]

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

[jyn514]

Thanks for your PR and sorry for the delay. I've changed my mind about the best way to improve the experience here, I left a suggestion as a comment. Sorry for the churn.

[jyn514]

Thanks! I was unclear, sorry - this change is good, but I wanted to keep your code deleting the stage1 and stage0-sysroot, so people don't use them by accident.

[chenyukang]

Thanks! I was unclear, sorry - this change is good, but I wanted to keep your code deleting the stage1 and stage0-sysroot, so people don't use them by accident.

Ah, I just forgetted the original idea of this issue 🤣
updated the code.

[jyn514]

Thanks!

@bors r+

[bors]

📌 Commit 60b39ba has been approved by jyn514

It is now in the queue for this repository.

[jyn514]

bors seems confused on https://bors.rust-lang.org/queue/rust ...

@bors r- r+

[bors]

📌 Commit 60b39ba has been approved by jyn514

It is now in the queue for this repository.

[bors]

⌛ Testing commit 60b39ba with merge e42c4d7...

[bors]

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing e42c4d7 to master...

[rust-timer]

Finished benchmarking commit (e42c4d7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-1.0%, -0.2%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.0%, 2.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³