Skip to content

add ptr::from_{ref,mut} #104977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2022
Merged

add ptr::from_{ref,mut} #104977

merged 2 commits into from
Dec 24, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 27, 2022

We have methods to avoid almost all as casts around raw pointer handling, except for the initial cast from reference to raw pointer. These new methods close that gap.

(I also moved null_mut next to null to keep the file consistently organized.)

r? libs-api

Tracking issue: #106116

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@RalfJung
Copy link
Member Author

@rust-lang/libs-api how do we make progress on this PR? It's just been sitting here for 3 weeks now.

@dtolnay dtolnay assigned dtolnay and unassigned yaahc Dec 23, 2022
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Please file a tracking issue.

@RalfJung RalfJung mentioned this pull request Dec 24, 2022
3 tasks
@RalfJung
Copy link
Member Author

@bors r=dtolnay

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

📌 Commit 15f72dd has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2022
@bors
Copy link
Collaborator

bors commented Dec 24, 2022

⌛ Testing commit 15f72dd with merge ccbb3295ef7b6c51c1f5a1e9d5019f33b05ab64d...

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 24, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@dtolnay
Copy link
Member

dtolnay commented Dec 24, 2022

curl: (6) Could not resolve host: ci-mirrors.rust-lang.org

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2022
@bors
Copy link
Collaborator

bors commented Dec 24, 2022

⌛ Testing commit 15f72dd with merge 7e4f466...

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 7e4f466 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2022
@bors bors merged commit 7e4f466 into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7e4f466): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@RalfJung RalfJung deleted the ptr-from-ref branch December 27, 2022 11:02
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
add ptr::from_{ref,mut}

We have methods to avoid almost all `as` casts around raw pointer handling, except for the initial cast from reference to raw pointer. These new methods close that gap.

(I also moved `null_mut` next to `null` to keep the file consistently organized.)

r? libs-api

Tracking issue: rust-lang#106116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants