Change some pub to pub(crate) in std

[clubby789]

Most of this was done by enabling warn(unreachable_pub) and using x fix library/std. It's incomplete and doesn't leave the lint enabled as cargo fix doesn't recurse through path dependencies, and only covers items which trigger on my system (x86-64 GNU Linux).

EDIT: Just wanted to note that the motivation for this was #107884, where a very unsound function, only used in tests, was both pub and not marked unsafe

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[clubby789]

I have a feeling this is going to take a few iterations to get the windows CI to pass so
@rustbot author

[clubby789]

Decided not to touch sys for now because of difficulties with testing it.
@rustbot ready

[Mark-Simulacrum]

Nominating for libs. I think this merits a decision on whether we want to do this or not at the team level given how impactful this is across the standard library. (If we do, then incrementally doing so seems ok, and then enabling the lint as we finish with most of the crate. I would probably enable earlier and allow it in e.g. the sys module tree though.

[m-ou-se]

We discussed this in today's libs meeting. We're generally in favor of doing this (thanks!), but we do want to enable the lint to make sure no new not-actually-pub pub items get added. (If that's too much work to do in one go, please open a tracking issue to track the migration towards pub(crate) in std, to track this and future PRs.)

Also, it seems there are a lot of items that could be pub(super), and while that's not a blocker, it'd be nice if we could limit items to pub(super) where possible, as that helps with readability. (Maybe there should be a lint that can warn when pub(super) would've been enough?)

[clubby789]

I was able to get most of std automatically pub(crate)'d - the allows are for

• backtrace - included from a submodule, so I can't fix it here
• sys/sys_common/os - I can't test/fix all platforms, I'll look at adding an internal deny for the modules I can test here

I'll work on seeing how much of the pub(crate) here can be made pub(super)
@rustbot author

[bors]

☔ The latest upstream changes (presumably #108538) made this pull request unmergeable. Please resolve the merge conflicts.

[Dylan-DPC]

@clubby789 any updates on this?

[clubby789]

I'm going to close this for now, as I'm not sure I have the time to make sure this is all done correctly right now 🙁

(Maybe there should be a lint that can warn when pub(super) would've been enough?)

I think this would be a good step to approach first which I might find time to look into 😓