-
Notifications
You must be signed in to change notification settings - Fork 13.3k
NonZero<Int>: add conversions (From/TryFrom) for floats and other integer types #108198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @scottmcm (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@rustbot label +T-libs-api -T-libs |
You need an ACP for all additions now, and libs-api oversight is particularly important for things like traits (that are insta-stable), even more so here since the PR build is demonstrating that this will cause inference breakage. r? rust-lang/libs-api |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Closing this as no ACP was created, which with that plus the time it takes for acp to be merged is long enough that this pr will remain stale for a long time. |
We have add conversions between different integer types for quite some time but never had them
for non-zero types.
I added the
const
forms of the impls to #87852 because it mentioned them already. Tell me if Ishould create a new tracking issue instead.