Skip to content

Bump thin-vec version to pick up inline attributes #108245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Feb 19, 2023

This bumps the thin-vec version to pick up Gankra/thin-vec#44 since the len method was not inlined in the query system.

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@Noratrieb
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2023
@bors
Copy link
Collaborator

bors commented Feb 20, 2023

⌛ Trying commit 06593900cc647c3eed0c4e8211e6011d4b991e4e with merge 0ce21dd312fae07a51e5e16e0e430d5f40a7f68a...

@bors
Copy link
Collaborator

bors commented Feb 20, 2023

☀️ Try build successful - checks-actions
Build commit: 0ce21dd312fae07a51e5e16e0e430d5f40a7f68a (0ce21dd312fae07a51e5e16e0e430d5f40a7f68a)

1 similar comment
@bors
Copy link
Collaborator

bors commented Feb 20, 2023

☀️ Try build successful - checks-actions
Build commit: 0ce21dd312fae07a51e5e16e0e430d5f40a7f68a (0ce21dd312fae07a51e5e16e0e430d5f40a7f68a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0ce21dd312fae07a51e5e16e0e430d5f40a7f68a): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2023
@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 21, 2023

Let's make that v0.2.12 to pick up Gankra/thin-vec#45 too.

@klensy
Copy link
Contributor

klensy commented Feb 21, 2023

this already updated by #104754 ?

@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 21, 2023

I guess it snuck in there.

@Zoxc Zoxc closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants