-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update compiler-builtins to 0.1.91 to bring in msp430 shift primitive… #109756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
These commits modify the If this was intentional then you can ignore this comment. |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Update compiler-builtins to 0.1.91 to bring in msp430 shift primitive… … fixes. This fixes unsoundness on MSP430 where `compiler-builtins` and LLVM didn't agree on the width of the shift amount argument of the shifting primitives (4 bytes vs 2 bytes). See rust-lang/compiler-builtins#522 for more details.
☀️ Test successful - checks-actions |
Finished benchmarking commit (1767585): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
… fixes.
This fixes unsoundness on MSP430 where
compiler-builtins
and LLVM didn't agree on the width of the shift amount argument of the shifting primitives (4 bytes vs 2 bytes). See rust-lang/compiler-builtins#522 for more details.