Populate effective visibilities in 'rustc_privacy' #110907

Bryanskiy · 2023-04-27T16:30:59Z

Next part of RFC #48054.

rustbot · 2023-04-27T16:31:10Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

compiler/rustc_middle/src/middle/privacy.rs

compiler/rustc_privacy/src/lib.rs

Bryanskiy · 2023-05-02T14:20:03Z

@rustbot ready

compiler/rustc_privacy/src/lib.rs

compiler/rustc_middle/src/middle/privacy.rs

petrochenkov · 2023-05-02T15:47:02Z

@bors try @rust-timer queue

bors · 2023-05-02T15:47:13Z

⌛ Trying commit 2dde54e6fd723b4e4c394184d4317aa3152eabd7 with merge 5e51bd5d58485b696cc9637960f1b3a0542f2f6d...

bors · 2023-05-02T17:59:07Z

☀️ Try build successful - checks-actions
Build commit: 5e51bd5d58485b696cc9637960f1b3a0542f2f6d (5e51bd5d58485b696cc9637960f1b3a0542f2f6d)

rust-timer · 2023-05-02T19:53:36Z

Finished benchmarking commit (5e51bd5d58485b696cc9637960f1b3a0542f2f6d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.5%]	43
Regressions ❌ (secondary)	0.9%	[0.2%, 2.5%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.2%, 1.5%]	43

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.4%, 2.8%]	3
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.873s -> 657.124s (0.04%)

bors · 2023-05-06T04:20:10Z

💔 Test failed - checks-actions

petrochenkov · 2023-05-06T08:59:07Z

We'll also be able to work on microoptimizations later, similarly to #102026.

#111260 pretty much compensates regressions from this PR.

petrochenkov · 2023-05-06T09:05:39Z

The job x86_64-mingw-1 failed!

Let's check whether it's spurious.
I did test this PR locally, including this test, and didn't observe any issues.
@bors retry

bors · 2023-05-06T17:48:26Z

⌛ Testing commit cff85f2 with merge 31a4f2d...

bors · 2023-05-06T20:25:57Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 31a4f2d to master...

bors · 2023-05-06T20:25:57Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 31a4f2d to master...

klensy · 2023-05-06T20:55:30Z

library/core/src/iter/adapters/flatten.rs

@@ -310,6 +310,7 @@ where
 /// Real logic of both `Flatten` and `FlatMap` which simply delegate to
 /// this type.
 #[derive(Clone, Debug)]
+#[unstable(feature = "trusted_len", issue = "37572")]


Unexpected to see it there

From what I see FlattenCompat is in a where clause of a public item, so it's considered leaked (reachable).
Requirements for stability attributes are pretty conservative, they are required on reachable items even if they are not nameable (exported).

rust-timer · 2023-05-06T21:40:54Z

Finished benchmarking commit (31a4f2d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.6%]	72
Regressions ❌ (secondary)	0.5%	[0.2%, 1.2%]	15
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.2%, 1.6%]	72

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 653.763s -> 653.481s (-0.04%)

Manishearth · 2023-05-08T16:40:37Z

This regressed missing_debug_implementations: #111359

(and likely has regressed other things)

…rochenkov Revert "Populate effective visibilities in `rustc_privacy`" This reverts commit cff85f2, cc rust-lang#110907. It needs to be fixed, but there are too many issues being reported that I wanted to put up a revert until a proper fix can be committed. Fixes a ton of issues where private but still reachable impls were missing during codegen: Fixes rust-lang#111320 Fixes rust-lang#111321 Fixes rust-lang#111334 Fixes rust-lang#111357 Fixes rust-lang#111368 Fixes rust-lang#111373 Fixes rust-lang#111377 Fixes rust-lang#111386 Fixes rust-lang#111387 `@bors` p=1 r? `@petrochenkov`

Populate effective visibilities in `rustc_privacy` (take 2) Same as rust-lang#110907 + regressions fixes. Fixes rust-lang#111359. r? `@petrochenkov`

Populate effective visibilities in `rustc_privacy` (take 2) Same as rust-lang/rust#110907 + regressions fixes. Fixes rust-lang/rust#111359. r? `@petrochenkov`

rustc_privacy: Cleanups and perf improvements to `EmbargoVisitor` Continuation of rust-lang#110907.

rustc_privacy: Cleanups and perf improvements to `EmbargoVisitor` Continuation of rust-lang/rust#110907.

Populate effective visibilities in `rustc_privacy` (take 2) Same as rust-lang/rust#110907 + regressions fixes. Fixes rust-lang/rust#111359. r? `@petrochenkov`

rustbot assigned petrochenkov Apr 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 27, 2023

Bryanskiy force-pushed the privacy_ef branch from b35e195 to 2ecadfe Compare April 27, 2023 16:39

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

petrochenkov reviewed Apr 28, 2023

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2023

Bryanskiy force-pushed the privacy_ef branch from 2ecadfe to 538663a Compare April 29, 2023 13:04

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2023

petrochenkov reviewed May 2, 2023

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 2, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 6, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2023

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label May 6, 2023

bors added merged-by-bors This PR was explicitly merged by bors. labels May 6, 2023

bors merged commit 31a4f2d into rust-lang:master May 6, 2023

rustbot added this to the 1.71.0 milestone May 6, 2023

klensy reviewed May 6, 2023

View reviewed changes

lukas-code mentioned this pull request May 7, 2023

ICE: compiler/rustc_monomorphize/src/collector.rs:1038:9: no MIR available #111320

Closed

Manishearth mentioned this pull request May 8, 2023

Regression: missing_debug_implementations linting on private items when used as parameter in trait impl #111359

Closed

compiler-errors mentioned this pull request May 8, 2023

Revert "Populate effective visibilities in rustc_privacy" #111371

Merged

Bryanskiy mentioned this pull request May 10, 2023

Populate effective visibilities in rustc_privacy (take 2) #111425

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request May 24, 2023

Auto merge of rust-lang#111260 - petrochenkov:effvisperf7, r=cjgillot

c373194

rustc_privacy: Cleanups and perf improvements to `EmbargoVisitor` Continuation of rust-lang#110907.

saethlin pushed a commit to saethlin/miri that referenced this pull request May 26, 2023

Auto merge of #111260 - petrochenkov:effvisperf7, r=cjgillot

0952c14

rustc_privacy: Cleanups and perf improvements to `EmbargoVisitor` Continuation of rust-lang/rust#110907.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Populate effective visibilities in 'rustc_privacy' #110907

Populate effective visibilities in 'rustc_privacy' #110907

Bryanskiy commented Apr 27, 2023

rustbot commented Apr 27, 2023

This comment has been minimized.

This comment was marked as resolved.

This comment has been minimized.

This comment has been minimized.

Bryanskiy commented May 2, 2023

petrochenkov commented May 2, 2023

This comment has been minimized.

bors commented May 2, 2023

bors commented May 2, 2023

This comment has been minimized.

rust-timer commented May 2, 2023

bors commented May 6, 2023

petrochenkov commented May 6, 2023

petrochenkov commented May 6, 2023

bors commented May 6, 2023

bors commented May 6, 2023

bors commented May 6, 2023

klensy May 6, 2023

petrochenkov May 6, 2023

rust-timer commented May 6, 2023

Manishearth commented May 8, 2023

Populate effective visibilities in 'rustc_privacy' #110907

Populate effective visibilities in 'rustc_privacy' #110907

Conversation

Bryanskiy commented Apr 27, 2023

rustbot commented Apr 27, 2023

This comment has been minimized.

This comment was marked as resolved.

This comment has been minimized.

This comment has been minimized.

Bryanskiy commented May 2, 2023

petrochenkov commented May 2, 2023

This comment has been minimized.

bors commented May 2, 2023

bors commented May 2, 2023

This comment has been minimized.

rust-timer commented May 2, 2023

Overall result: ❌ regressions - ACTION NEEDED

bors commented May 6, 2023

petrochenkov commented May 6, 2023

petrochenkov commented May 6, 2023

bors commented May 6, 2023

bors commented May 6, 2023

bors commented May 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rust-timer commented May 6, 2023

Overall result: ❌ regressions - ACTION NEEDED

Manishearth commented May 8, 2023