-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Prevent crash when a path is not resolved in intra-doc link #111195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbd1c9f
to
1fd99ff
Compare
So the problem was that |
r? @petrochenkov |
Which is a good thing. The previous version was a lazy fix from my end. Now it's ready. |
1fd99ff
to
f396cbc
Compare
@GuillaumeGomez |
f396cbc
to
bcdfda1
Compare
I applied your patch @petrochenkov. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d69787f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 647.271s -> 647.352s (0.01%) |
Documenting our code triggers an ICE in rust 1.70, presumably the one fixed here: rust-lang/rust#111195
Fixes #111189.
cc @petrochenkov
r? @notriddle