Skip to content

Disallow leading underscores in float exponents. #114567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Disallow leading underscores in float exponents. #114567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion compiler/rustc_lexer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,14 @@ impl Cursor<'_> {
if self.first() == '-' || self.first() == '+' {
self.bump();
}
self.eat_decimal_digits()
match self.first() {
'0'..='9' => {
self.bump();
self.eat_decimal_digits();
true
}
_ => false,
}
}

// Eats the suffix of the literal, e.g. "u8".
Expand Down
12 changes: 12 additions & 0 deletions tests/ui/lexer/lex-bad-numeric-literals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@ fn main() {
0x9.0e-9; //~ ERROR: hexadecimal float literal is not supported
0o; //~ ERROR: no valid digits
1e+; //~ ERROR: expected at least one digit in exponent
1e_3;
//~^ ERROR: invalid suffix `_3` for float literal
//~| ERROR: expected at least one digit in exponent
1E+__3;
//~^ ERROR: invalid suffix `__3` for float literal
//~| ERROR: expected at least one digit in exponent
1e-______3_3;
//~^ ERROR: invalid suffix `______3_3` for float literal
//~| ERROR: expected at least one digit in exponent
1em;
//~^ ERROR: invalid suffix `m` for float literal
//~| ERROR: expected at least one digit in exponent
0x539.0; //~ ERROR: hexadecimal float literal is not supported
9900000000000000000000000000999999999999999999999999999999;
//~^ ERROR: integer literal is too large
Expand Down
88 changes: 72 additions & 16 deletions tests/ui/lexer/lex-bad-numeric-literals.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,50 +58,74 @@ error: expected at least one digit in exponent
LL | 1e+;
| ^^^

error: hexadecimal float literal is not supported
error: expected at least one digit in exponent
--> $DIR/lex-bad-numeric-literals.rs:15:5
|
LL | 1e_3;
| ^^^^

error: expected at least one digit in exponent
--> $DIR/lex-bad-numeric-literals.rs:18:5
|
LL | 1E+__3;
| ^^^^^^

error: expected at least one digit in exponent
--> $DIR/lex-bad-numeric-literals.rs:21:5
|
LL | 1e-______3_3;
| ^^^^^^^^^^^^

error: expected at least one digit in exponent
--> $DIR/lex-bad-numeric-literals.rs:24:5
|
LL | 1em;
| ^^^

error: hexadecimal float literal is not supported
--> $DIR/lex-bad-numeric-literals.rs:27:5
|
LL | 0x539.0;
| ^^^^^^^

error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:26:5
--> $DIR/lex-bad-numeric-literals.rs:38:5
|
LL | 0x;
| ^^

error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:27:5
--> $DIR/lex-bad-numeric-literals.rs:39:5
|
LL | 0xu32;
| ^^

error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:28:5
--> $DIR/lex-bad-numeric-literals.rs:40:5
|
LL | 0ou32;
| ^^

error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:29:5
--> $DIR/lex-bad-numeric-literals.rs:41:5
|
LL | 0bu32;
| ^^

error[E0768]: no valid digits found for number
--> $DIR/lex-bad-numeric-literals.rs:30:5
--> $DIR/lex-bad-numeric-literals.rs:42:5
|
LL | 0b;
| ^^

error: octal float literal is not supported
--> $DIR/lex-bad-numeric-literals.rs:32:5
--> $DIR/lex-bad-numeric-literals.rs:44:5
|
LL | 0o123.456;
| ^^^^^^^^^

error: binary float literal is not supported
--> $DIR/lex-bad-numeric-literals.rs:34:5
--> $DIR/lex-bad-numeric-literals.rs:46:5
|
LL | 0b111.101;
| ^^^^^^^^^
Expand All @@ -112,58 +136,90 @@ error: octal float literal is not supported
LL | 0o2f32;
| ^^^^^^ not supported

error: invalid suffix `_3` for float literal
--> $DIR/lex-bad-numeric-literals.rs:15:5
|
LL | 1e_3;
| ^^^^ invalid suffix `_3`
|
= help: valid suffixes are `f32` and `f64`

error: invalid suffix `__3` for float literal
--> $DIR/lex-bad-numeric-literals.rs:18:5
|
LL | 1E+__3;
| ^^^^^^ invalid suffix `__3`
|
= help: valid suffixes are `f32` and `f64`

error: invalid suffix `______3_3` for float literal
--> $DIR/lex-bad-numeric-literals.rs:21:5
|
LL | 1e-______3_3;
| ^^^^^^^^^^^^ invalid suffix `______3_3`
|
= help: valid suffixes are `f32` and `f64`

error: invalid suffix `m` for float literal
--> $DIR/lex-bad-numeric-literals.rs:24:5
|
LL | 1em;
| ^^^ invalid suffix `m`
|
= help: valid suffixes are `f32` and `f64`

error: integer literal is too large
--> $DIR/lex-bad-numeric-literals.rs:16:5
--> $DIR/lex-bad-numeric-literals.rs:28:5
|
LL | 9900000000000000000000000000999999999999999999999999999999;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: value exceeds limit of `340282366920938463463374607431768211455`

error: integer literal is too large
--> $DIR/lex-bad-numeric-literals.rs:18:5
--> $DIR/lex-bad-numeric-literals.rs:30:5
|
LL | 9900000000000000000000000000999999999999999999999999999999;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: value exceeds limit of `340282366920938463463374607431768211455`

error: integer literal is too large
--> $DIR/lex-bad-numeric-literals.rs:20:5
--> $DIR/lex-bad-numeric-literals.rs:32:5
|
LL | 0b111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111110;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: value exceeds limit of `0b11111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111`

error: integer literal is too large
--> $DIR/lex-bad-numeric-literals.rs:22:5
--> $DIR/lex-bad-numeric-literals.rs:34:5
|
LL | 0o37777777777777777777777777777777777777777770;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: value exceeds limit of `0o3777777777777777777777777777777777777777777`

error: integer literal is too large
--> $DIR/lex-bad-numeric-literals.rs:24:5
--> $DIR/lex-bad-numeric-literals.rs:36:5
|
LL | 0xffffffffffffffffffffffffffffffff0;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: value exceeds limit of `0xffffffffffffffffffffffffffffffff`

error: octal float literal is not supported
--> $DIR/lex-bad-numeric-literals.rs:31:5
--> $DIR/lex-bad-numeric-literals.rs:43:5
|
LL | 0o123f64;
| ^^^^^^^^ not supported

error: binary float literal is not supported
--> $DIR/lex-bad-numeric-literals.rs:33:5
--> $DIR/lex-bad-numeric-literals.rs:45:5
|
LL | 0b101f64;
| ^^^^^^^^ not supported

error: aborting due to 26 previous errors
error: aborting due to 34 previous errors

For more information about this error, try `rustc --explain E0768`.