-
Notifications
You must be signed in to change notification settings - Fork 13.3k
add tests which assert that import list for simple executable not changed silently #121494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
This comment has been minimized.
This comment has been minimized.
7ff4a0e
to
3d28626
Compare
3d28626
to
9bae569
Compare
Is there are reason this in particular is useful? I would expect this to change as the C runtime changes between versions. And also a fair bit on the Rust side over time, especially around now as we're moving to a Windows 10 baseline. |
Yes, but runtime changes not every day, same is true for transition to Windows 10 baseline (windows dependency list should be quite stable, but don't know about linux ones). Plus this is additional guard against issues like #85441, #108714 (comment) |
I'll probably add more variations to tests, like lto and stuff, they cut import list quite nice ,for example for |
@klensy any updates on this? thanks |
While I remain nervous about this (e.g. the CRT could add or remove DLLs) I am broadly in favour. Maybe with the modern rust run-make tests we could use the object crate to gather imports? And, for Windows, compare with a list of known functions for Windows 1507? That would seem more robust than having to add or remove imports if something changes. |
added tests for
x86_64-pc-windows-msvc
andx86_64-unknown-linux-gnu