Enable deny(unused_crate_dependencies) in all compiler/ crates.

Cargo.lock

@@ -4205,7 +4205,6 @@ dependencies = [
  "rustc_middle",
  "rustc_span",
  "rustc_target",
- "rustc_type_ir",
  "smallvec",
  "tracing",
 ]
@@ -4323,7 +4322,6 @@ dependencies = [
 name = "rustc_log"
 version = "0.0.0"
 dependencies = [
- "rustc_span",
  "tracing",
  "tracing-core",
  "tracing-subscriber",

compiler/rustc_abi/src/lib.rs

@@ -2,6 +2,7 @@
 #![cfg_attr(feature = "nightly", allow(internal_features))]
 #![cfg_attr(feature = "nightly", doc(rust_logo))]
 #![cfg_attr(feature = "nightly", feature(rustdoc_internals))]
+#![deny(unused_crate_dependencies)]
 
 use std::fmt;
 use std::num::{NonZeroUsize, ParseIntError};

compiler/rustc_arena/src/lib.rs

@@ -22,6 +22,7 @@
 #![cfg_attr(test, feature(test))]
 #![feature(strict_provenance)]
 #![deny(unsafe_op_in_unsafe_fn)]
+#![deny(unused_crate_dependencies)]
 #![allow(internal_features)]
 #![allow(clippy::mut_from_ref)] // Arena allocators are one of the places where this pattern is fine.
 

compiler/rustc_ast/src/lib.rs

@@ -10,6 +10,7 @@
 )]
 #![doc(rust_logo)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![feature(associated_type_defaults)]
 #![feature(box_patterns)]

compiler/rustc_ast_ir/src/lib.rs

@@ -1,6 +1,7 @@
 #![cfg_attr(feature = "nightly", feature(never_type))]
 #![cfg_attr(feature = "nightly", feature(rustc_attrs))]
 #![cfg_attr(feature = "nightly", allow(internal_features))]
+#![deny(unused_crate_dependencies)]
 
 #[cfg(feature = "nightly")]
 use rustc_macros::{Decodable, Encodable, HashStable_NoContext};

compiler/rustc_ast_lowering/src/lib.rs

@@ -31,6 +31,7 @@
 //! in the HIR, especially for multiple identifiers.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![feature(assert_matches)]

compiler/rustc_ast_passes/src/lib.rs

@@ -5,6 +5,7 @@
 //! The crate also contains other misc AST visitors, e.g. `node_count` and `show_span`.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![doc(rust_logo)]
 #![feature(rustdoc_internals)]
 #![feature(box_patterns)]

compiler/rustc_ast_pretty/src/lib.rs

@@ -1,4 +1,5 @@
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![feature(box_patterns)]

compiler/rustc_attr/src/lib.rs

@@ -5,6 +5,7 @@
 //! to this crate.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![feature(let_chains)]

compiler/rustc_baked_icu_data/src/lib.rs

@@ -21,6 +21,7 @@
 //! ```
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![allow(elided_lifetimes_in_paths)]

compiler/rustc_borrowck/src/lib.rs

@@ -1,6 +1,7 @@
 //! This query borrow-checks the MIR to (further) ensure it is not broken.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![feature(assert_matches)]

compiler/rustc_builtin_macros/src/lib.rs

@@ -4,6 +4,7 @@
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]

compiler/rustc_codegen_llvm/src/lib.rs

@@ -5,6 +5,7 @@
 //! This API is completely unstable and subject to change.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]

compiler/rustc_codegen_ssa/src/lib.rs

@@ -4,6 +4,7 @@
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![feature(box_patterns)]
 #![feature(if_let_guard)]
 #![feature(let_chains)]

compiler/rustc_const_eval/src/lib.rs

@@ -1,5 +1,6 @@
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![feature(assert_matches)]

compiler/rustc_data_structures/src/lib.rs

@@ -12,6 +12,7 @@
 #![allow(rustc::potential_query_instability)]
 #![cfg_attr(not(parallel_compiler), feature(cell_leak))]
 #![deny(unsafe_op_in_unsafe_fn)]
+#![deny(unused_crate_dependencies)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![feature(allocator_api)]

compiler/rustc_driver/src/lib.rs

@@ -2,6 +2,7 @@
 // `rustc_driver_impl` to be compiled in parallel with other crates.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 

compiler/rustc_driver_impl/src/lib.rs

@@ -9,6 +9,7 @@
 #![doc(rust_logo)]
 #![feature(rustdoc_internals)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(decl_macro)]
 #![feature(let_chains)]
 #![feature(panic_backtrace_config)]

compiler/rustc_error_codes/src/lib.rs

@@ -5,6 +5,7 @@
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![deny(rustdoc::invalid_codeblock_attributes)]
+#![deny(unused_crate_dependencies)]
 
 // This higher-order macro defines the error codes that are in use. It is used
 // in the `rustc_errors` crate. Removed error codes are listed in the comment

compiler/rustc_errors/src/lib.rs

@@ -7,6 +7,7 @@
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![feature(array_windows)]

compiler/rustc_expand/src/lib.rs

@@ -1,6 +1,7 @@
 // tidy-alphabetical-start
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
+#![deny(unused_crate_dependencies)]
 #![doc(rust_logo)]
 #![feature(array_windows)]
 #![feature(associated_type_defaults)]

compiler/rustc_feature/src/lib.rs

@@ -12,6 +12,7 @@
 //! symbol to the `accepted` or `removed` modules respectively.
 
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 

compiler/rustc_fluent_macro/src/lib.rs

@@ -1,6 +1,7 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 #![feature(rustdoc_internals)]
 #![feature(proc_macro_diagnostic)]
 #![feature(proc_macro_span)]

compiler/rustc_fs_util/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_crate_dependencies)]
+
 use std::ffi::CString;
 use std::fs;
 use std::io;

compiler/rustc_graphviz/src/lib.rs

@@ -276,6 +276,7 @@
 #![feature(rustdoc_internals)]
 #![doc(rust_logo)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 
 use LabelText::*;
 

compiler/rustc_hir/src/lib.rs

@@ -9,6 +9,7 @@
 #![feature(rustc_attrs)]
 #![feature(variant_count)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 
 extern crate self as rustc_hir;
 

compiler/rustc_hir_analysis/src/lib.rs

@@ -58,6 +58,7 @@ This API is completely unstable and subject to change.
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::potential_query_instability)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![feature(rustdoc_internals)]

compiler/rustc_hir_pretty/src/lib.rs

@@ -1,6 +1,7 @@
 //! HIR pretty-printing is layered on top of AST pretty-printing. A number of
 //! the definitions in this file have equivalents in `rustc_ast_pretty`.
 
+#![deny(unused_crate_dependencies)]
 #![recursion_limit = "256"]
 
 use rustc_ast as ast;

compiler/rustc_hir_typeck/src/lib.rs

@@ -1,5 +1,6 @@
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![feature(if_let_guard)]
 #![feature(let_chains)]
 #![feature(try_blocks)]

compiler/rustc_incremental/src/lib.rs

@@ -1,6 +1,7 @@
 //! Support for serializing the dep-graph and reloading it.
 
 #![deny(missing_docs)]
+#![deny(unused_crate_dependencies)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![feature(rustdoc_internals)]

compiler/rustc_index/src/lib.rs

@@ -4,6 +4,7 @@
 )]
 #![cfg_attr(all(feature = "nightly", test), feature(stmt_expr_attributes))]
 #![cfg_attr(feature = "nightly", allow(internal_features))]
+#![deny(unused_crate_dependencies)]
 
 pub mod bit_set;
 #[cfg(feature = "nightly")]

compiler/rustc_index_macros/src/lib.rs

@@ -1,5 +1,6 @@
 #![cfg_attr(feature = "nightly", feature(allow_internal_unstable))]
 #![cfg_attr(feature = "nightly", allow(internal_features))]
+#![deny(unused_crate_dependencies)]
 
 use proc_macro::TokenStream;
 

compiler/rustc_infer/Cargo.toml

@@ -18,7 +18,6 @@ rustc_macros = { path = "../rustc_macros" }
 rustc_middle = { path = "../rustc_middle" }
 rustc_span = { path = "../rustc_span" }
 rustc_target = { path = "../rustc_target" }
-rustc_type_ir = { path = "../rustc_type_ir" }
 smallvec = { version = "1.8.1", features = ["union", "may_dangle"] }
 tracing = "0.1"
 # tidy-alphabetical-end

compiler/rustc_infer/src/lib.rs

@@ -18,6 +18,7 @@
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![feature(box_patterns)]
 #![feature(control_flow_enum)]
 #![feature(extend_one)]

compiler/rustc_interface/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_crate_dependencies)]
 #![feature(decl_macro)]
 #![feature(let_chains)]
 #![feature(thread_spawn_unchecked)]

compiler/rustc_lexer/src/lib.rs

@@ -22,6 +22,7 @@
 // We want to be able to build this crate with a stable compiler,
 // so no `#![feature]` attributes should be added.
 #![deny(unstable_features)]
+#![deny(unused_crate_dependencies)]
 
 mod cursor;
 pub mod unescape;

compiler/rustc_lint/src/lib.rs

@@ -38,6 +38,7 @@
 #![feature(trait_upcasting)]
 #![feature(rustc_attrs)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 
 mod async_fn_in_trait;
 pub mod builtin;

compiler/rustc_lint_defs/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_crate_dependencies)]
+
 pub use self::Level::*;
 use rustc_ast::node_id::NodeId;
 use rustc_ast::{AttrId, Attribute};

compiler/rustc_llvm/src/lib.rs

@@ -2,6 +2,7 @@
 #![doc(rust_logo)]
 #![feature(rustdoc_internals)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 
 // NOTE: This crate only exists to allow linking on mingw targets.
 

compiler/rustc_log/Cargo.toml

@@ -11,11 +11,6 @@ tracing-subscriber = { version = "0.3.3", default-features = false, features = [
 tracing-tree = "0.3.0"
 # tidy-alphabetical-end
 
-[dev-dependencies]
-# tidy-alphabetical-start
-rustc_span = { path = "../rustc_span" }
-# tidy-alphabetical-end
-
 [features]
 # tidy-alphabetical-start
 max_level_info = ['tracing/max_level_info']

compiler/rustc_log/src/lib.rs

@@ -38,6 +38,8 @@
 //! debugging, you can make changes inside those crates and quickly run main.rs
 //! to read the debug logs.
 
+#![deny(unused_crate_dependencies)]
+
 use std::env::{self, VarError};
 use std::fmt::{self, Display};
 use std::io::{self, IsTerminal};

compiler/rustc_macros/src/lib.rs

@@ -7,6 +7,7 @@
 #![feature(proc_macro_tracked_env)]
 #![allow(rustc::default_hash_types)]
 #![allow(internal_features)]
+#![deny(unused_crate_dependencies)]
 
 use synstructure::decl_derive;
 

compiler/rustc_metadata/src/lib.rs

@@ -1,6 +1,7 @@
 // tidy-alphabetical-start
 #![allow(internal_features)]
 #![allow(rustc::potential_query_instability)]
+#![deny(unused_crate_dependencies)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![feature(coroutines)]

compiler/rustc_middle/src/lib.rs

@@ -28,6 +28,7 @@
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::potential_query_instability)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
 #![doc(rust_logo)]
 #![feature(allocator_api)]

compiler/rustc_mir_build/src/lib.rs

@@ -2,6 +2,7 @@
 
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![feature(assert_matches)]
 #![feature(box_patterns)]
 #![feature(if_let_guard)]

compiler/rustc_mir_dataflow/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_crate_dependencies)]
 #![feature(associated_type_defaults)]
 #![feature(box_patterns)]
 #![feature(exact_size_is_empty)]

compiler/rustc_mir_transform/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_crate_dependencies)]
 #![feature(assert_matches)]
 #![feature(box_patterns)]
 #![feature(const_type_name)]

compiler/rustc_monomorphize/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_crate_dependencies)]
 #![feature(array_windows)]
 #![feature(is_sorted)]
 

compiler/rustc_next_trait_solver/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_crate_dependencies)]
+
 pub mod canonicalizer;
 pub mod resolve;
 pub mod solve;

compiler/rustc_parse/src/lib.rs

@@ -3,6 +3,7 @@
 #![allow(internal_features)]
 #![allow(rustc::diagnostic_outside_of_impl)]
 #![allow(rustc::untranslatable_diagnostic)]
+#![deny(unused_crate_dependencies)]
 #![feature(array_windows)]
 #![feature(box_patterns)]
 #![feature(debug_closure_helpers)]

compiler/rustc_parse_format/src/lib.rs

@@ -12,6 +12,7 @@
 // We want to be able to build this crate with a stable compiler,
 // so no `#![feature]` attributes should be added.
 #![deny(unstable_features)]
+#![deny(unused_crate_dependencies)]
 
 use rustc_lexer::unescape;
 pub use Alignment::*;