Skip to content

Stabilize tcp_quickack #129121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Aug 15, 2024

to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage.

The related API calls are the following

// std::os::linux::net

// sealed trait, implemented for std::net::TcpStream
pub trait TcpStreamExt: Sealed{
  fn quickack(&self) -> io::Result<bool>;
  fn set_quickack(&self, quickack: bool) -> io::Result<()>;
}

Closes: #96256

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2024
@rust-log-analyzer

This comment has been minimized.

to stabilise the quickack part for now, tcp_deferaccept had been added at a
later stage.
@devnexen devnexen force-pushed the stabilize_ext_linux_tcp_layer branch from d40c8a7 to 1666f86 Compare August 15, 2024 12:41
@ChrisDenton
Copy link
Member

This needs a stabilization fcp

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 15, 2024
@rustbot rustbot assigned BurntSushi and unassigned ChrisDenton Aug 15, 2024
@tgross35
Copy link
Contributor

@devnexen could you add an API summary to the top post? Like #129401

@devnexen
Copy link
Contributor Author

done.

@tgross35 tgross35 changed the title proposal to expand (a subset of) linux specific socket capabilities. Stabilize tcp_quickack Oct 22, 2024
@tgross35 tgross35 added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Oct 22, 2024
@tgross35
Copy link
Contributor

Nominating to put this on the radar

@rustbot label +I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 27, 2025
@Amanieu Amanieu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 29, 2025
@joshtriplett
Copy link
Member

This has been around for a while and seems reasonable.

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Apr 29, 2025

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. O-android Operating system: Android O-linux Operating system: Linux proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for TCP_QUICKACK support on Linux
9 participants