-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Subpart10 for async drop (major4) - StateTransform pass improvements #129746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
azhogin
wants to merge
10
commits into
rust-lang:master
Choose a base branch
from
azhogin:azhogin/async-drop-subpart10-state-transform
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Subpart10 for async drop (major4) - StateTransform pass improvements #129746
azhogin
wants to merge
10
commits into
rust-lang:master
from
azhogin:azhogin/async-drop-subpart10-state-transform
+2,501
−2,095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2024
b52aadb
to
c57d5af
Compare
cbd1df8
to
871da65
Compare
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @nikomatsakis is going to look into this |
0ee2814
to
231903b
Compare
…p from previous async drop glue implementation
231903b
to
6a45a6d
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #139578) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 10 PR of #123948, just for review purposes.
Async drop in StateTransform pass may be expanded into additional yield point or reset to sync version (
drop
andasync_fut
terminator fields reset toNone
).Added generation of async drop poll function for coroutine itself (
create_coroutine_drop_shim_async
).Review only last commit, based on previous PR #129745.