Skip to content

Document powf and powi values that are always 1.0 (f32) #136013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jan 24, 2025

f32 part for bug #90429

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025
hkBst and others added 2 commits January 24, 2025 18:19
@matthiaskrgr
Copy link
Member

#136012
#136013
#136014
#136015

wouldn't it make sense to squash all of these into a single commit?

@hkBst
Copy link
Member Author

hkBst commented Jan 24, 2025

@matthiaskrgr maybe if the effort to payout ratio was better?

EDIT: I meant "payoff" here, not "payout"! But I can see that I misjudged the value people place on this...

@matthiaskrgr
Copy link
Member

The way I see it, it takes much more effort for 3-4 people to review each of these PRs individually instead of having one person just look at one PR that incorporates all the changes at once.

Just need to merge all the branches into a single one and then rebase into a single commit, that should only take a minute or two. 🙂

@hkBst
Copy link
Member Author

hkBst commented Jan 24, 2025

@matthiaskrgr the amount to review won't change, and there is nothing stopping the first reviewer from picking up the other three...

@compiler-errors
Copy link
Member

Please merge this into #136012 and avoid opening up 4 PRs -- there's no reason to split this over 4 PRs, since they all work towards the same goal.

@hkBst hkBst deleted the patch-23 branch January 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants