-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Document powf and powi values that are always 1.0 (f32) #136013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
Co-authored-by: matthewjasper <[email protected]>
@matthiaskrgr maybe if the effort to payout ratio was better? EDIT: I meant "payoff" here, not "payout"! But I can see that I misjudged the value people place on this... |
The way I see it, it takes much more effort for 3-4 people to review each of these PRs individually instead of having one person just look at one PR that incorporates all the changes at once. Just need to merge all the branches into a single one and then rebase into a single commit, that should only take a minute or two. 🙂 |
@matthiaskrgr the amount to review won't change, and there is nothing stopping the first reviewer from picking up the other three... |
Please merge this into #136012 and avoid opening up 4 PRs -- there's no reason to split this over 4 PRs, since they all work towards the same goal. |
f32 part for bug #90429