Don't install msys2 in CI #136588
Open
Don't install msys2 in CI #136588
+0
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-msvc doesn't need it and windows-gnu has its own version
rustbot
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2025
Don't install msys2 in CI windows-msvc doesn't need it and windows-gnu installs its own version This might still fail on window-msvc if it turns out we need to setup Visual Studio in `PATH`. I don't know how the default `bash` is configured. This will fail on the one remaining run-make test but let's see if it gets that far. try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: i686-mingw try-job: x86_64-mingw-1 r? ghost
|
☀️ Try build successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-msvc doesn't need it and windows-gnu installs its own version
This might still fail on window-msvc if it turns out we need to setup Visual Studio in
PATH. I don't know how the defaultbashis configured. This will fail on the one remaining Makefile test but let's see if it gets that far.try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: i686-mingw
try-job: x86_64-mingw-1
r? ghost