Implement cfg_os_version_min
#136867
Draft
Implement cfg_os_version_min
#136867
+600
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in compiler/rustc_attr_parsing These commits modify compiler targets. |
This was referenced Feb 11, 2025
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-blocked
Hmm, I was hoping to resolve those in future PRs, since I believe this feature is useful to the standard library today (or rather yesterday), regardless of future semantics and syntax. Would it help if I renamed it to |
|
You should ask T-lang to approve this PR as an "T-lang experiment", that way it could implemented in the compiler even without an FCP on the RFC. |
madsmtm
force-pushed
the
cfg_os_version_min
branch
from
6125af0 to
bb55488
Compare
Right, that's what it's called, couldn't remember, thanks! (filed #136871 so that I'll be able to find it in the future) |
This comment has been minimized.
This comment has been minimized.
Probably worth trying this as a T-lang experiment yeah |
jieyouxu
added
S-waiting-on-author
SparrowLii
reviewed
Feb 12, 2025
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 12, 2025
…=scottmcm dev-guide: Link to `t-lang` procedures for new features I was confused in rust-lang#136867, because while I did remember that such a procedure existed, but I couldn't seem to find it in the dev guide.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 12, 2025
Rollup merge of rust-lang#136871 - madsmtm:link-to-lang-procedures, r=scottmcm dev-guide: Link to `t-lang` procedures for new features I was confused in rust-lang#136867, because while I did remember that such a procedure existed, but I couldn't seem to find it in the dev guide.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Feb 13, 2025
dev-guide: Link to `t-lang` procedures for new features I was confused in rust-lang/rust#136867, because while I did remember that such a procedure existed, but I couldn't seem to find it in the dev guide.
|
☔ The latest upstream changes (presumably #137046) made this pull request unmergeable. Please resolve the merge conflicts. |
madsmtm
force-pushed
the
cfg_os_version_min
branch
from
bb55488 to
2a44225
Compare
|
Some changes occurred in compiler/rustc_codegen_ssa |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #139037) made this pull request unmergeable. Please resolve the merge conflicts. |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 4, 2025
…=Noratrieb Refactor Apple version handling in the compiler Move various Apple version handling code in the compiler out `rustc_codegen_ssa` and into a place where it can be accessed by `rustc_attr_parsing`, which I found to be necessary when doing rust-lang#136867. Thought I'd split it out to make it easier to land, and to make further changes like rust-lang#131477 have fewer conflicts / PR dependencies. There should be no functional changes in this PR. `@rustbot` label O-apple r? rust-lang/compiler
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 4, 2025
…=Noratrieb Refactor Apple version handling in the compiler Move various Apple version handling code in the compiler out `rustc_codegen_ssa` and into a place where it can be accessed by `rustc_attr_parsing`, which I found to be necessary when doing rust-lang#136867. Thought I'd split it out to make it easier to land, and to make further changes like rust-lang#131477 have fewer conflicts / PR dependencies. There should be no functional changes in this PR. ``@rustbot`` label O-apple r? rust-lang/compiler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2025
…oratrieb Refactor Apple version handling in the compiler Move various Apple version handling code in the compiler out `rustc_codegen_ssa` and into a place where it can be accessed by `rustc_attr_parsing`, which I found to be necessary when doing rust-lang#136867. Thought I'd split it out to make it easier to land, and to make further changes like rust-lang#131477 have fewer conflicts / PR dependencies. There should be no functional changes in this PR. `@rustbot` label O-apple r? rust-lang/compiler
madsmtm
force-pushed
the
cfg_os_version_min
branch
from
2a44225 to
b15e23c
Compare
This comment has been minimized.
This comment has been minimized.
madsmtm
force-pushed
the
cfg_os_version_min
branch
from
b15e23c to
bf8be08
Compare
This comment has been minimized.
This comment has been minimized.
madsmtm
force-pushed
the
cfg_os_version_min
branch
from
bf8be08 to
b440c36
Compare
This comment has been minimized.
This comment has been minimized.
Based on in-progress RFC: rust-lang/rfcs#3750. Only implemented for Apple platforms for now, but written in a way that should be easily expandable to include other platforms.
madsmtm
force-pushed
the
cfg_os_version_min
branch
from
b440c36 to
00bdfcc
Compare
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 7, 2025
Refactor Apple version handling in the compiler Move various Apple version handling code in the compiler out `rustc_codegen_ssa` and into a place where it can be accessed by `rustc_attr_parsing`, which I found to be necessary when doing rust-lang/rust#136867. Thought I'd split it out to make it easier to land, and to make further changes like rust-lang/rust#131477 have fewer conflicts / PR dependencies. There should be no functional changes in this PR. `@rustbot` label O-apple r? rust-lang/compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
cfg_os_version_minfeature that is being RFC'd in rust-lang/rfcs#3750, tracking issue #136866. This implementation only handles Apple targets, but it should be fairly easy to add support for other targets after this.The RFC is not finalized, and as such things may change (especially the syntax). Regardless, I think it makes sense to start experimenting with it; even if the feature is ultimately rejected, it is necessary for the standard library (an example is that it would allow us to ship #122408 without a dangerous fallback).
Using this in the standard library is done in a draft PR.
CC @ChrisDenton @BlackHoleFox
@rustbot label O-apple
r? rust-lang/compiler