Add std::os::unix::process::CommandExt::chroot to safely chroot a child process
#137759
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hild process This adds a `chroot` method to the `CommandExt` extension trait for the `Command` builder, to set a directory to chroot into. This will chroot the child process into that directory right before calling chdir for the `Command`'s working directory. To avoid allowing a process to have a working directory outside of the chroot, if the `Command` does not yet have a working directory set, `chroot` will set its working directory to "/".
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
O-unix
joshtriplett
added
T-libs-api
workingjubilee
added
S-waiting-on-ACP
|
☔ The latest upstream changes (presumably #136929) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
tbu-
reviewed
Mar 31, 2025
Comment on lines
+206
to
+208
| /// that directory will be relative to the new root. If no directory has been specified with | ||
| /// `Command::current_dir`, this will set the directory to `/`, to avoid leaving the current | ||
| /// directory outside the chroot. |
There was a problem hiding this comment.
Usually, Rust is a thin wrapper around operating system functionality. The idea is that the user can implement chroot themselves if they want a chroot with a working directory outside of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
chrootmethod to theCommandExtextension trait for theCommandbuilder, to set a directory to chroot into. This will chrootthe child process into that directory right before calling chdir for the
Command's working directory.To avoid allowing a process to have a working directory outside of the
chroot, if the
Commanddoes not yet have a working directory set,chrootwill set its working directory to "/".ACP: rust-lang/libs-team#551
This PR currently has the tracking issue set to "none"; if the ACP is approved,
I'll file a tracking issue and update the PR.