Skip to content

Implement pick[23]_mut via get_disjoint_mut [rustc cleanup] #138196 #138204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Implement pick[23]_mut via get_disjoint_mut [rustc cleanup] #138196 #138204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa4023
Implement pick[23]_mut via get_disjoint_mut [rustc cleanup] #138196
UjwalReddyKotla Mar 8, 2025
dae0cad
Implement pick[23]_mut via get_disjoint_mut [rustc cleanup] #138196
UjwalReddyKotla Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions compiler/rustc_index/src/slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,29 +118,15 @@ impl<I: Idx, T> IndexSlice<I, T> {
/// Panics if `a == b`.
#[inline]
pub fn pick2_mut(&mut self, a: I, b: I) -> (&mut T, &mut T) {
let (ai, bi) = (a.index(), b.index());
assert!(ai != bi);

if ai < bi {
let (c1, c2) = self.raw.split_at_mut(bi);
(&mut c1[ai], &mut c2[0])
} else {
let (c2, c1) = self.pick2_mut(b, a);
(c1, c2)
}
self.raw.get_disjoint_mut([a.index(), b.index()]).unwrap().into()
}

/// Returns mutable references to three distinct elements.
///
/// Panics if the elements are not distinct.
#[inline]
pub fn pick3_mut(&mut self, a: I, b: I, c: I) -> (&mut T, &mut T, &mut T) {
let (ai, bi, ci) = (a.index(), b.index(), c.index());
assert!(ai != bi && bi != ci && ci != ai);
let len = self.raw.len();
assert!(ai < len && bi < len && ci < len);
let ptr = self.raw.as_mut_ptr();
unsafe { (&mut *ptr.add(ai), &mut *ptr.add(bi), &mut *ptr.add(ci)) }
self.raw.get_disjoint_mut([a.index(), b.index(), c.index()]).unwrap().into()
}

#[inline]
Expand Down
Loading