Report line number of test when should_panic test failed #138603

xizheyin · 2025-03-17T12:13:13Z

try-job: x86_64-gnu-llvm-19-3
try-job: test-various

rustbot · 2025-03-17T12:13:17Z

Failed to set assignee to joshka: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot · 2025-03-17T12:13:20Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2025-03-17T12:14:20Z

Could not assign reviewer from: jieyouxu.
User(s) jieyouxu are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

jieyouxu · 2025-03-17T13:47:47Z

This looks like a libtest change, so r? libs (or testing-devex?)

joshka

Test names are nits, but make the reason for each test self describing.

I think it probably makes sense to also fix the substring tests if they're also broken (I haven't manually checked those messages to see if there's span info coming from elsewhere in the stack, but these seem like they should be tested with the same tests as are introduced here).

tests/ui/test-should-panic-failed-show-span.rs

library/test/src/test_result.rs

tests/ui/test-should-panic-failed-show-span.run.stdout

joshka

Generally LGTM - small nits

(Note: I'm not a member of the rust project, so this likely still requires approval from someone who is)

library/test/src/test_result.rs

jieyouxu · 2025-03-18T03:14:05Z

(Note: I'm not a member of the rust project, so this likely still requires approval from someone who is)

Though reviews are still very much appreciated 😁

weihanglo · 2025-03-18T21:00:26Z

@bors try

Before the change fails snapshots in Cargo's test testsuite

compiletest: Trim whitespace from environment variable names When a test contains a directive like `//@ exec-env: FOO=bar`, compiletest currently includes that leading space in the name of the environment variable, so it is defined as ` FOO` instead of `FOO`. This is an annoying footgun that is pretty much never intended, especially since most other directives *do* trim whitespace. So let's get rid of it by trimming the environment variable name. Values remain untrimmed, since there could conceivably be a use-case for values with leading space, but perhaps we'll end up trimming values too in the future. Recently observed in rust-lang#138603 (comment). Fixes rust-lang#132990. Supersedes rust-lang#133148. --- try-job: test-various

Rollup merge of rust-lang#139507 - Zalathar:trim-env-name, r=jieyouxu compiletest: Trim whitespace from environment variable names When a test contains a directive like `//@ exec-env: FOO=bar`, compiletest currently includes that leading space in the name of the environment variable, so it is defined as ` FOO` instead of `FOO`. This is an annoying footgun that is pretty much never intended, especially since most other directives *do* trim whitespace. So let's get rid of it by trimming the environment variable name. Values remain untrimmed, since there could conceivably be a use-case for values with leading space, but perhaps we'll end up trimming values too in the future. Recently observed in rust-lang#138603 (comment). Fixes rust-lang#132990. Supersedes rust-lang#133148. --- try-job: test-various

chenyukang · 2025-04-13T12:18:34Z

@bors r=chenyukang

bors · 2025-04-13T12:18:37Z

📌 Commit ee3b557 has been approved by chenyukang

It is now in the queue for this repository.

Report line number of test when should_panic test failed Closes rust-lang#137405 --- try-job: x86_64-gnu-llvm-19-3 try-job: test-various

bors · 2025-04-13T18:57:04Z

☔ The latest upstream changes (presumably #139746) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: xizheyin <[email protected]>

chenyukang · 2025-04-14T03:50:35Z

@bors r=chenyukang

bors · 2025-04-14T03:50:38Z

📌 Commit dc3a586 has been approved by chenyukang

It is now in the queue for this repository.

bors · 2025-04-14T13:33:47Z

⌛ Testing commit dc3a586 with merge 07d3fd1...

bors · 2025-04-14T16:44:02Z

☀️ Test successful - checks-actions
Approved by: chenyukang
Pushing 07d3fd1 to master...

github-actions · 2025-04-14T16:45:26Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c580c49 (parent) -> 07d3fd1 (this PR)

Test differences

Show 2 test diffs

Stage 1

[ui] tests/ui/test-attrs/test-should-panic-failed-show-span.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/test-attrs/test-should-panic-failed-show-span.rs: [missing] -> pass (J1)

Job group index

Job duration changes

x86_64-apple-2: 6506.7s -> 4224.2s (-35.1%)
x86_64-apple-1: 8751.6s -> 6490.8s (-25.8%)
dist-apple-various: 6608.8s -> 8156.5s (23.4%)
dist-x86_64-apple: 7945.5s -> 9705.4s (22.1%)
dist-aarch64-apple: 4890.0s -> 5408.4s (10.6%)
x86_64-gnu-debug: 6140.2s -> 6614.0s (7.7%)
dist-i686-mingw: 7878.0s -> 8443.1s (7.2%)
dist-x86_64-freebsd: 4909.8s -> 5205.4s (6.0%)
dist-x86_64-mingw: 7544.5s -> 7949.1s (5.4%)
dist-powerpc64-linux: 5406.1s -> 5674.4s (5.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-04-14T18:00:44Z

Finished benchmarking commit (07d3fd1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.5%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.7%, -0.4%]	5
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-0.5%	[-0.7%, -0.4%]	5

Cycles

Results (primary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-2.3%, 0.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 784.038s -> 784.108s (0.01%)
Artifact size: 365.12 MiB -> 365.13 MiB (0.00%)

Report line number of test when should_panic test failed Closes rust-lang#137405 --- try-job: x86_64-gnu-llvm-19-3 try-job: test-various

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot assigned Mark-Simulacrum Mar 17, 2025

This comment was marked as resolved.

Sign in to view

rustbot assigned joboet and unassigned Mark-Simulacrum Mar 17, 2025

xizheyin marked this pull request as draft March 17, 2025 14:03

xizheyin force-pushed the issue-137405 branch from f0882e5 to e57ab34 Compare March 17, 2025 14:22

xizheyin marked this pull request as ready for review March 17, 2025 14:23

This comment has been minimized.

Sign in to view

joshka reviewed Mar 17, 2025

View reviewed changes

xizheyin force-pushed the issue-137405 branch 2 times, most recently from 21b9d4f to c7b4523 Compare March 18, 2025 01:17

xizheyin commented Mar 18, 2025

View reviewed changes

tests/ui/test-should-panic-failed-show-span.run.stdout Outdated Show resolved Hide resolved

joshka approved these changes Mar 18, 2025

View reviewed changes

library/test/src/test_result.rs Outdated Show resolved Hide resolved

library/test/src/test_result.rs Outdated Show resolved Hide resolved

library/test/src/test_result.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

xizheyin force-pushed the issue-137405 branch from c7b4523 to a164290 Compare March 18, 2025 06:36

joshka approved these changes Mar 18, 2025

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025

ChrisDenton mentioned this pull request Apr 13, 2025

Rollup of 13 pull requests #139754

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2025

xizheyin added 2 commits April 14, 2025 10:36

Report span of test when should_panic test failed

c73598f

Signed-off-by: xizheyin <[email protected]>

Adjust test directives

dc3a586

Signed-off-by: xizheyin <[email protected]>

xizheyin force-pushed the issue-137405 branch from ee3b557 to dc3a586 Compare April 14, 2025 02:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2025

bors merged commit 07d3fd1 into rust-lang:master Apr 14, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report line number of test when should_panic test failed #138603

Report line number of test when should_panic test failed #138603

xizheyin commented Mar 17, 2025 •

edited by Zalathar

Loading

rustbot commented Mar 17, 2025

rustbot commented Mar 17, 2025

This comment was marked as outdated.

rustbot commented Mar 17, 2025

This comment has been minimized.

jieyouxu commented Mar 17, 2025

This comment was marked as resolved.

This comment has been minimized.

joshka left a comment

joshka left a comment

This comment has been minimized.

jieyouxu commented Mar 18, 2025

weihanglo commented Mar 18, 2025

chenyukang commented Apr 13, 2025

bors commented Apr 13, 2025

bors commented Apr 13, 2025

chenyukang commented Apr 14, 2025

bors commented Apr 14, 2025

bors commented Apr 14, 2025

bors commented Apr 14, 2025

github-actions bot commented Apr 14, 2025

Stage 1

Stage 2

rust-timer commented Apr 14, 2025

Report line number of test when should_panic test failed #138603

Report line number of test when should_panic test failed #138603

Conversation

xizheyin commented Mar 17, 2025 • edited by Zalathar Loading

rustbot commented Mar 17, 2025

rustbot commented Mar 17, 2025

This comment was marked as outdated.

rustbot commented Mar 17, 2025

This comment has been minimized.

jieyouxu commented Mar 17, 2025

This comment was marked as resolved.

This comment has been minimized.

joshka left a comment

Choose a reason for hiding this comment

joshka left a comment

Choose a reason for hiding this comment

This comment has been minimized.

jieyouxu commented Mar 18, 2025

weihanglo commented Mar 18, 2025

chenyukang commented Apr 13, 2025

bors commented Apr 13, 2025

bors commented Apr 13, 2025

chenyukang commented Apr 14, 2025

bors commented Apr 14, 2025

bors commented Apr 14, 2025

bors commented Apr 14, 2025

github-actions bot commented Apr 14, 2025

Test differences

Stage 1

Stage 2

Job duration changes

rust-timer commented Apr 14, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

xizheyin commented Mar 17, 2025 •

edited by Zalathar

Loading