Sanitizers target modificators

[azhogin]

Depends on bool flag fix: #138483.

Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer

For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier.

Many test errors was with sanizer flags inconsistent with std deps. Tests are fixed with -C unsafe-allow-abi-mismatch.

[rustbot]

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in tests/codegen/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

[bors]

☔ The latest upstream changes (presumably #138974) made this pull request unmergeable. Please resolve the merge conflicts.

[BoxyUwU]

r? compiler

[Darksonn]

Do we have any tests that check simultaneous use of multiple sanitizers? For example, if I enable both shadow-call-stack and kcfi at the same time, then both must also be enabled in deps.

[rcvalle]

@rustbot claim

[rcvalle]

Nit: Should test file names be separated by hyphen ('-') instead?

[rcvalle]

Do we have any tests that check simultaneous use of multiple sanitizers? For example, if I enable both shadow-call-stack and kcfi at the same time, then both must also be enabled in deps.

Unfortunately, I don't think we do at this moment. (Others feel free to correct me if I'm wrong.) Something somewhat related that I also wanted us to have that we don't at the moment is build core and std and run their tests with some sanitizers enabled, such as CFI to make sure they currently work and no regressions/explicit CFI violations are introduced.

[azhogin]

Renamed '_' to '-' in tests, added test with safestack + kcfi sanitizers. Btw, which target supports both kcfi and shadow-call-stack in the example?

About core/std build with sanitizers - I am not sure, how to integrate it to the current test system. Won't it be an overkill to build several versions of core/std in test procedure?