Update the index of Option to make the summary more comprehensive #138957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
hello? @Amanieu |
|
Both of them have been updated according to the review. Any further comments? @Amanieu |
Amanieu
reviewed
Apr 22, 2025
|
Added the as_ref() example referencing https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#137653 (Deprecate the unstable `concat_idents!`) - rust-lang#138957 (Update the index of Option to make the summary more comprehensive) - rust-lang#140006 (ensure compiler existance of tools on the dist step) - rust-lang#140143 (Move `sys::pal::os::Env` into `sys::env`) - rust-lang#140202 (Make #![feature(let_chains)] bootstrap conditional in compiler/) - rust-lang#140236 (norm nested aliases before evaluating the parent goal) - rust-lang#140257 (Some drive-by housecleaning in `rustc_borrowck`) - rust-lang#140278 (Don't use item name to look up associated item from trait item) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 25, 2025
…oc, r=Amanieu Update the index of Result to make the summary more comprehensive fix rust-lang#138966 This PR and rust-lang#138957 are twin PR r? `@Amanieu`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2025
Rollup merge of rust-lang#138957 - Natural-selection1:update-Option-doc, r=Amanieu Update the index of Option to make the summary more comprehensive fix: rust-lang#138955 This PR and rust-lang#138968 are twin PR By the way, this is my first time contributing to rust, and I'm not a native English speaker, so any suggestions—whether about the wording in the docs or the contribution process itself—would be greatly appreciated!
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2025
Rollup merge of rust-lang#138968 - Natural-selection1:update-Result-doc, r=Amanieu Update the index of Result to make the summary more comprehensive fix rust-lang#138966 This PR and rust-lang#138957 are twin PR r? `@Amanieu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #138955
This PR and #138968 are twin PR
By the way, this is my first time contributing to rust, and I'm not a native English speaker, so any suggestions—whether about the wording in the docs or the contribution process itself—would be greatly appreciated!