Rollup of 7 pull requests #139634
Merged
Rollup of 7 pull requests #139634
+2,014
−508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consistent handling, invalid handles are always an abort - Helper for reading handles that does the checking and machine stop - Use real handle types more places - Adds `File` and `Invalid` types of handle. File support will be added next
… enough to get file metadata.
Support getting file metadata on Windows
triagebot: enable `[canonicalize-issue-links]` and `[no-mentions]`
It bugs me when variables of type `Ident` are called `name`. It leads to silly things like `name.name`. `Ident` variables should be called `ident`, and `name` should be used for variables of type `Symbol`. This commit improves things by by doing `s/name/ident/` on a bunch of `Ident` variables. Not all of them, but a decent chunk.
Note that some of the output is currently bogus, with missing params and
args:
```
fn add(: _, : _) -> _ { m::add(, ) }
```
The next commit will fix this.
Instead use `argN`. The empty identifiers could flow to `Liveness::should_warn`, where they would trigger a bounds error. Fixes rust-lang#139512.
… for Futex support
Implement FreeBSD syscall _umtx_op for futex support
The value is moved in pin!().
path: add more Windows tests
fix "still mutable" ice while metrics are enabled Resolves "still mutable" ICE discovered by `@matthiaskrgr` here: [#t-docs-rs > metrics intitiative @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/356853-t-docs-rs/topic/metrics.20intitiative/near/510490790) This was caused by invoking `crate_hash` before the `definitions` struct was frozen here: https://github.com/rust-lang/rust/blob/e643f59f6da3a84f43e75dea99afaa5b041ea6bf/compiler/rustc_interface/src/passes.rs#L951 resolved by moving metrics dumping to occur after `analysis` freezes the definitions I'm guessing we didn't discover this in CI because the problem only occurs when you try to calculate the crash hash with incremental compilation enabled when it tries to freeze the definitions here: https://github.com/rust-lang/rust/blob/e643f59f6da3a84f43e75dea99afaa5b041ea6bf/compiler/rustc_middle/src/hir/map.rs#L1172 my understanding is that this causes us to freeze the definitions too early in compilation, then we subsequently try to mutate them, likely during `analysis`, and this causes the ICE. r? `@bjorn3`
…dead Rename some `name` variables as `ident`. It bugs me when variables of type `Ident` are called `name`. It leads to silly things like `name.name`. `Ident` variables should be called `ident`, and `name` should be used for variables of type `Symbol`. This commit improves things by by doing `s/name/ident/` on a bunch of `Ident` variables. Not all of them, but a decent chunk. r? `@fee1-dead`
…r=compiler-errors Update compiletest to Edition 2024 r? bootstrap (or compiler) try-job: x86_64-apple-1 try-job: x86_64-msvc-1 try-jbo: x86_64-mingw-1
…Kobzol
compiletest: don't use stringly paths for `compose_and_run`
Eventually I'd like to fully migrate to `camino`'s `{Utf8Path,Utf8PathBuf}` because compiletest assumes UTF-8 paths all over the place, so this is an precursor change to make the migration diff cleaner.
r? `@Kobzol` (or bootstrap/compiler)
Avoid empty identifiers for delegate params and args. Details in individual commits. r? `@oli-obk`
Remove unnecessary `mut` in test. The value is moved in `pin!()`, so the binding doesn't need to be `mut` itself. (Rustc doesn't warn about this due to the current hacky implementation of `pin!()`. That is fixed by rust-lang#139114.)
Miri subtree update r? `@ghost` a sync is needed to fix the miri-test-libstd failures
rustbot
added
A-run-make
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 69b3959 (parent) -> 2205455 (this PR) Test differencesShow 57 test diffsStage 1
Stage 2
Additionally, 52 doctest diffs were found. These are ignored, as they are noisy. Job group index
Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 69b3959afe In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (2205455): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.4%, secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 782.988s -> 783.243s (0.03%) |
|
Looks to be just bimodality, not a real regression. |
There was a problem hiding this comment.
Copilot reviewed 93 out of 94 changed files in this pull request and generated no comments.
Files not reviewed (1)
- compiler/rustc_hir_analysis/messages.ftl: Language not supported
Comments suppressed due to low confidence (2)
compiler/rustc_data_structures/src/sync/freeze.rs:91
- [nitpick] Ensure that the updated error message aligns with the project's overall messaging style and concisely conveys the issue.
self.try_write().expect("data should not be frozen if we're still attempting to mutate it")
compiler/rustc_driver_impl/src/lib.rs:369
- Verify that moving the dump_feature_usage_metrics call after analysis does not affect the timing or side effects expected by downstream components.
if let Some(metrics_dir) = &sess.opts.unstable_opts.metrics_dir {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
namevariables asident. #139510 (Rename somenamevariables asident.)compose_and_run#139609 (compiletest: don't use stringly paths forcompose_and_run)mutin test. #139626 (Remove unnecessarymutin test.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup